Support for new parameters #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This identifies and adds the according datatype to several parameters that have been identified to be related to the operating time of the machine. Essentially most of it is tracked in seconds, while some other parameters keep track of the counts. - `Zaehler` refers to the German word for counter. - `BetrZeit` refers to the German word for "operating time" - `WP` stands for "Wärmepumpe", the German word for heat pump. - `ZWE` refers to `Zusätzlicher Wärmeerzeuger`, essentially heating rods, etc. - `Imp` refers to `Impulse`, the German word for "impulses" and/or "cycles". - `Hz` refers to the German word "Heizung", i.e. "heating" - `BW` refers to the German word "Brauchwasser", i.e. hot water - `SW` refers to the German word `Schwimmwasser", i.e. swimming pool water - `Kue` refers to the Terman word "Kühlung", i.e. cooling. The necessary datatypes have already been available.
This adds newly identified parameters related to the energy usage. The
appropriate parameters are currently named:
```
+ 878: Energy("ID_Waermemenge_BW"),
+ 879: Energy("ID_Waermemenge_SW"),
+ 880: Timestamp("ID_Waermemenge_Datum"),
```
- `Waermemenge` refers to the German word for "amount of heat".
- `BW` refers to `Brauchwasser`, the German word for hot water.
- `SW` (probably) refers to `Schwimmwasser` the German word for pool water.
This is also a mode that is supported.
- `Datum` refers to "date", which is the date when this data has been
reset the last time.
Luckily the datatypes have already been available, so they are just
assigned to those parameters. Since it doesn't make sense to write those
parameters, safe mode is not turned on in these cases.
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bouni
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for newly identified parameters. The datatype have already been available, so it comes down to assigning the correct datatype to the appropriate parameter. The commits in this series provide additional information about those new parameters.