Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for YouTube Music links to the application, allowing users to create Instagram Story cards from both YouTube and YouTube Music content. The implementation leverages the shared backend between YouTube and YouTube Music, making the changes relatively straightforward.
Key Changes
- Added YouTube Music URL parsing support via the
music.youtube.comdomain - Extended the
YouTubeVideodata class with anappproperty to distinguish between YouTube and YouTube Music - Added YouTube Music logo asset and display logic to show the appropriate logo on generated cards
- Updated all user-facing text and documentation to reflect support for both platforms
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
android/app/src/main/java/hu/sarmin/yt2ig/ShareTarget.kt |
Added YouTubeApp enum and YouTube Music URL parsing logic; updated YouTubeVideo to track source app |
android/app/src/main/java/hu/sarmin/yt2ig/YouTube.kt |
Modified getVideoInfo to accept YouTubeVideo object instead of video ID string; added app field to YouTubeVideoInfo |
android/app/src/main/java/hu/sarmin/yt2ig/Card.kt |
Added logic to select appropriate logo based on source app (YouTube vs YouTube Music) |
android/app/src/main/java/hu/sarmin/yt2ig/ImageStore.kt |
Added YOUTUBE_MUSIC_LOGO preset and loaded YouTube Music logo asset |
android/app/src/main/java/hu/sarmin/yt2ig/CardCreationService.kt |
Updated service call to pass full YouTubeVideo object instead of just video ID |
android/app/src/test/java/hu/sarmin/yt2ig/RealYouTubeServiceTest.kt |
Updated test calls to use YouTubeVideo object |
android/app/src/main/java/hu/sarmin/yt2ig/ui/HomeScreen.kt |
Updated UI text to mention YouTube Music support |
android/app/src/main/java/hu/sarmin/yt2ig/ui/HelpScreen.kt |
Updated help text to mention YouTube Music support |
android/app/src/main/res/values/strings.xml |
Updated error message to mention YouTube Music |
android/app/src/main/assets/logos/youtube_music.png |
Added YouTube Music logo asset (binary file) |
README.md |
Updated description to mention YouTube Music support; removed YouTube Music from roadmap |
site/index.html |
Updated marketing copy to mention YouTube Music support |
site/tos.html |
Made text more generic (removed "Welcome to") |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
I did not expect YouTube and YouTube Music to share a backend, but apparently they do, so implementing this was surprisingly easy. Closes #58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did not expect YouTube and YouTube Music to share a backend, but apparently they do, so implementing this was surprisingly easy.
Closes #58