Repository navigation
Preserve linked receiver diagnostics in pairing Save - #145
Merged
Merged
Conversation
Proxicon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final Save previously discarded NetRatel's receiver failure evidence and assigned a new RatelDesk reference. Preserve a validated, finite readiness stage/reason/status and the original safe reference through peer responses, Save failure and the final API/browser error. Raw exceptions, peer URLs and token responses are excluded, and the existing draft rollback, current authorization and same-pair retry remain in place.
Make the organization selector's expression binding explicit as requested. The corrected parent-component baseline already retained the actual selected ID with its original spelling, so this is a separate clarity correction and is not attributed to the downstream receiver failure. No incident capability URL, storage, identity, migration or deployment changes.
Validation: the two owning Save tests reproduced loss of the linked reference on released code; 36 focused checks passed with zero skips, including retained-draft retry, diagnostic masking and the actual parent component. The corrected selector control also passes with the original spelling. The diagnostic test generates its canonical correlation fixture at runtime; the same source scanner reports zero findings and all 28 transport tests pass. The bounded default-port HTTPS browser journey uses the real receiver and equal effective API settings: NR-generated code → RD-consumed fresh pair → incidents and automation → one Save connected; a released-API failure also recovered on the same retained draft/pair/mapping after replacing only NR API. Actual authenticated capabilities/target validation returned 200 and persisted current readiness is receiver-ready; no business execution occurred. Both fixtures were positively purged. Required routine CI remains unchanged.
Required PR CI: https://github.com/BostonTechnologies/rateldesk/actions/runs/37957416963 — 16m38 total (15m16 active, 1m22 initial queue); 1,799 general tests passed with six existing scaffold skips, plus 128/128 provider tests with zero skips. All required jobs executed successfully; optional deep jobs retain their existing condition.
Refs #143 and BostonTechnologies/netratel#180. Owner deployed acceptance remains failed pending the deployed retest.