Repository navigation
fix: recover NetRatel connections and prepare beta.19 - #142
Merged
Merged
Conversation
Proxicon
changed the title
Proxicon
marked this pull request as ready for review
October 8, 2026 15:15
11 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated NetRatel setup could reach approval and collide with an existing relationship, leaving a generic conflict page. Reuse exact pending proposals only for their original administrator/session, identify an existing relationship after local authorization, and return saved responder approval through its retained callback without creating another consent attempt.
The integration page now separates System connections from account credentials, folds old attempts into history, and shows the current setup's action and verification result. Focused consent and error pages retain the selected connection. Bounded status observation updates completed setup without replaying approval, and preserves an unchanged consent draft.
Validation: the two original recovery failures were reproduced before the fixes. The final combined Debug suite passed 172/172 cases, zero skips, in 2m57s. Actual source-backed browser checks passed desktop/narrow × light/dark tab interaction and text/icon visibility with no horizontal overflow. History and the focused connection form were also checked. Independent cross-repository review is complete.
The isolated running product pair completed both initiation directions, retained the same attempt through Resume and saved-consent return, and passed repeated authentication/incident-target verification. Reverse initiation completed automatic verification without Refresh. Synthetic monitoring input then traversed the actual evaluator, durable outbox, published Flow, authorization, connector and receiver: one committed incident matched its receipt, and identical replay returned the same receipt without a duplicate. This is source-pair validation; physical Client telemetry and deployed owner acceptance remain separate. Final hosted CI passed on 788d214: https://github.com/BostonTechnologies/rateldesk/actions/runs/37802485117. The receiver/provider acceptance job passed 239 cases with zero skips; full solution validation and disclosure/layout checks passed.
Follow-up to #138, paired with BostonTechnologies/netratel#179. Directory.Build.props is bumped to 0.1.1-beta.19 for the requested release. Immutable grants, original actor/session checks, pinned callbacks, tenant authorization, and relationship uniqueness remain enforced. No live deployment changes are included.