Feature: Add start & pause button per group in ping monitor - #3575
Merged
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds per-group Start and Pause controls to Ping Monitor.
Changes:
- Adds group-level start/pause commands and hover controls.
- Adds localized labels for the controls.
- Adds a changelog entry.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
Website/docs/changelog/next-release.md |
Documents the feature. |
Source/NETworkManager/Views/PingMonitorHostView.xaml |
Adds group action buttons. |
Source/NETworkManager/ViewModels/PingMonitorHostViewModel.cs |
Implements group actions. |
Source/NETworkManager.Localization/Resources/Strings.resx |
Adds English labels. |
Source/NETworkManager.Localization/Resources/Strings.Designer.cs |
Exposes generated labels. |
Files not reviewed (1)
- Source/NETworkManager.Localization/Resources/Strings.Designer.cs: Generated file
Suppressed comments (1)
Website/docs/changelog/next-release.md:58
- The PR checklist marks the user documentation update complete separately from the changelog, but
Website/docs/application/ping-monitor.mdstill contains no description of the new group controls. Add the Start/Pause group behavior and its hover discoverability to that page before keeping the item checked.
- Added **Start** and **Pause** buttons to each group header (shown next to the close button on mouse-over), to start every paused host in the group or pause every running one at once. [#3575](https://github.com/BornToBeRoot/NETworkManager/pull/3575)
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+310
to
+311
| <Grid Grid.Column="4" Grid.Row="0" | ||
| Visibility="{Binding Path=IsMouseOver, RelativeSource={RelativeSource Mode=FindAncestor, AncestorType={x:Type TypeName=Grid}}, Converter={StaticResource ResourceKey=BooleanToVisibilityCollapsedConverter}}"> |
| /// <summary> | ||
| /// Gets the command to start every host in a group that is not currently running. | ||
| /// </summary> | ||
| public ICommand StartGroupCommand => new RelayCommand(StartGroupAction); |
| **Ping Monitor** | ||
|
|
||
| - Added a live count of hosts up/down (and paused, if any) per group, next to the group's close button. [#3572](https://github.com/BornToBeRoot/NETworkManager/pull/3572) | ||
| - Added **Start** and **Pause** buttons to each group header (shown next to the close button on mouse-over), to start every paused host in the group or pause every running one at once. [#XXXX](https://github.com/BornToBeRoot/NETworkManager/pull/XXXX) |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- Source/NETworkManager.Localization/Resources/Strings.Designer.cs: Generated file
Suppressed comments (1)
Source/NETworkManager/Views/PingMonitorHostView.xaml:305
- The actions button is always visible: it has no
Visibilitybinding, andCleanButtondoes not hide it. This contradicts the PR description’s “visible on mouse over” claim. Keep the accessible always-visible behavior and update the PR description to match it.
<Button x:Name="GroupActionsButton"
Grid.Column="4" Grid.Row="0"
HorizontalAlignment="Right"
Tag="{Binding Path=(CollectionViewGroup.Name)}"
Click="GroupActionsButton_Click"
Style="{StaticResource ResourceKey=CleanButton}"
ToolTip="{x:Static Member=localization:Strings.GroupActions}">
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Related issue(s)
To-Do
Contributing
By submitting this pull request, I confirm the following: