Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Improve profile list performance #2014

Merged
merged 12 commits into from
Mar 10, 2023

Conversation

BornToBeRoot
Copy link
Owner

@BornToBeRoot BornToBeRoot commented Mar 9, 2023

Please provide some details about this pull request:

  • Remove SortDescriptions in CollectionViewSource and Refresh - Re-bind the datasource instead. It's somehow faster than calling Refresh()
  • Use virtualizing
  • Always show the scroll bar, because the performance is terrible if it is added on mouse over... maybe because the view is calculating the size again...
  • Improve code to load group, profiles & profiles list. Reduce calls to update the profiles.
  • Reselect or select first profile after search, add, edit, update, delete, etc.
  • Update rectangle styles (error & warning)
  • Check duplicate group is now case insensitive

Closes #1947
Fix #2019
Fix #2018

Bugs to fix:

  • Actions in Settings\Profiles trigger a profiles refresh in the main app even if it's not visible...

Implement:

  • NetworkInterface,
  • IPScanner,
  • PortScanner,
  • PingMonitor,
  • Traceroute,
  • DNSLookup,
  • RemoteDesktop,
  • PowerShell,
  • PuTTY,
  • AWSSessionManager,
  • TigerVNC,
  • WebConsole,
  • WakeOnLAN,
  • Whois

Tests:

Profiles / Hosts Result
500 Fast
1 k Fast
1,5 k Fast
2 k OK
2,5 k Slow
5 k Slow, but still works
10 k Unusable

ToDo:


By submitting this pull request, I confirm the following:

BornToBeRoot added a commit that referenced this pull request Mar 10, 2023
@BornToBeRoot BornToBeRoot marked this pull request as ready for review March 10, 2023 22:29
@mergify mergify bot merged commit a203f9c into main Mar 10, 2023
@mergify mergify bot deleted the feature/improve_profile_list_performance branch March 10, 2023 22:30
@BornToBeRoot BornToBeRoot added this to the next-release milestone Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant