Skip to content

Reuse bound connection to improve performance #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pgodel wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Reuse bound connection to improve performance #146

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d7129d
Reuse binded connection to improve performance
pgodel Dec 18, 2014
39999ec
Use array() for BC with older versions of PHP
pgodel Dec 18, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion Manager/LdapConnection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@ class LdapConnection implements LdapConnectionInterface

protected $ress;

/**
* Holds a list of resources per username (username=>resource) to allow for reusing binded connections.
* @var array
*/
protected $resources = array();

public function __construct(array $params, Logger $logger)
{
$this->params = $params;
Expand Down Expand Up @@ -64,7 +70,7 @@ public function search(array $params)

/**
* @return true
* @throws \IMAG\LdapBundle\Exceptions\ConnectionException | Connection error
* @throws \IMAG\LdapBundle\Exception\ConnectionException | Connection error
*/
public function bind($user_dn, $password = '', $ress = null)
{
Expand Down Expand Up @@ -128,6 +134,16 @@ private function connect()
? $this->params['client']['port']
: '389';

// check if there is a binded connection for this username, if there is, set $this->ress and return without
// doing it again.
$username = $this->params['client']['username'];
if (isset($this->params['client']['username'])) {
if (isset($this->resources[$username])) {
$this->ress = $this->resources[$username];
return $this;
}
}

$ress = @ldap_connect($this->params['client']['host'], $port);

if (isset($this->params['client']['version'])) {
Expand All @@ -151,6 +167,8 @@ private function connect()
$this->checkLdapError($ress);
}

// store resource per username to be reused later.
$this->resources[$username] = $ress;
$this->ress = $ress;

return $this;
Expand Down