Y-axis label issues

[kajensen]

The x-axis labels currently show up below the frame and the background is the color/alphaBottom. This is not the same for the y-axis. The background is the backgroundColor. This can be avoided by making the background a solid color, but any other styling will get you in trouble. The example looks fine, but a white backgroundColor with different alpha top/bottom has issues (that i'm currently experiencing).

Additionally, some y-axis labels are cutoff and only display "...". Personally, I would like to see this as just a smaller font if it cannot fit.

A way to avoid the above issues all together would to have the y-axis labels appear inside the graph's frame (with the y-axis). This would be the best solution to me.

I fixed this problem by revising the BEMSimpleLineGraphView.m line 588:

NSNumber *maximumValue = [self calculateMaximumPointValue]; 
NSNumber *maximumValue = [NSNumber numberWithInt:[self calculateMaximumPointValue].intValue]; // <-------------

[Sam-Spencer]

@kajensen Could you clarify the issue a little more? It sounds like a graphics bug, so any screenshots of this would be greatly appreciated. Thanks!

[kajensen]

I don't think it's a bug per se, yangkeith's solution works fine with changing the "..." to integers (i'm assuming the max/min's were floats and thus truncated.

But I think that the area below the x-axis' background color should be the same as the y-axis background color, not the color/alpha of the bottom section of the line. Right now the y-axis values look very disjoint from the rest of the graph. Allowing these sections outside of the frame either their own colors/alphas, or the same color/alpha of the top section would look best in my opinion.

[Boris-Em]

Hi @kajensen,
Thank you very much for the precisions and for opening this issue. I just pushed a commit to the master branch (5e25bc7) that should fix both these problems.
Could you please confirm that these problems are not repro anymore with the latest commit?

[kajensen]

thank you for the quick update! Here is what I have from implementing branch (5e25bc7) and the new attributes for x/y backgrounds. The x-axis background remains the same as the color/alpha bottom.

code:

        graphView.delegate = self;
        graphView.dataSource = self;
        graphView.enableBezierCurve = YES;
        graphView.enableYAxisLabel = YES;
        graphView.enableReferenceAxisFrame = YES;
        graphView.enableReferenceAxisLines = NO;
        graphView.colorBackgroundXaxis = [UIColor grayColor];
        graphView.colorBackgroundYaxis = [UIColor grayColor];
        graphView.alphaBackgroundXaxis = .5;
        graphView.alphaBackgroundYaxis = .5;
        graphView.colorXaxisLabel = [UIColor whiteColor];
        graphView.colorYaxisLabel = [UIColor whiteColor];

        graphView.colorLine = [UIColor whiteColor];
        graphView.alphaLine = 1.0;
        graphView.colorPoint = [UIColor clearColor];
        graphView.sizePoint = 0;
        graphView.backgroundColor = [UIColor whiteColor];    
        graphView.colorTop = [UIColor blueColor];
        graphView.alphaTop = .2;
        graphView.colorBottom = [UIColor blueColor];
        graphView.alphaBottom = .5;

        [graphView reloadGraph];

[Boris-Em]

@kajensen
Good catch! This was due to the fact that you were not using the frame. This should be fixed with the last commit on the Master branch (8ac5614).
Once again, if you could please confirm that this time everything is fixed that would be great!
Thank you very much for your contributions and sorry about the inconvenience of this bug!

[kajensen]

Everything looks good. Thanks for making this wonderful repo!

[Boris-Em]

Great! I'm glad you enjoy using the library!
Closed as fixed with commit 8ac5614.

[Supertecnoboff]

I had to set the following property, in order for the y axis labels to fit properly on screen:

[labelYAxis setAdjustsFontSizeToFitWidth:YES];