BEMSimpleLineGraph uses delegate for dataSource

[michaelarmstrong]

Perhaps I'm wrong (as I've only just started implementing this control in an app) but it seems at first glance (without running the code) that the delegate receiver is also used as a datasource?

I cannot find a dataSource property to set on the line graph itself either? If I am incorrect, ignore this; if I am correct, I will submit a PR so that the datasource and delegate can have different receivers (more flexible design).

[Boris-Em]

Hi @michaelarmstrong,
You're right, the delegate receiver is used as a datasource right now. If you have time, it would be great if you could submit a PR about that. Thank you!

[Sam-Spencer]

See commit 64a0aae on the feature branch for this fix! Now the data source and delegate are separated. I have also added warnings and deprecations for delegate methods which were moved to the data source.

[kajensen]

why do i get a warning for this line of code:
programmaticallyInstantiatedGraph.dataSource = self;
--> Assigning to 'id< BEMSimpleLineGraphDataSource >' from incompatible type 'ViewController * const__strong'

[Sam-Spencer]

Did you subscribe to the data source in your View Controller's header (between the <>)?

On Jun 25, 2014, at 4:04 PM, Kurt notifications@github.com wrote:

why do i get a warning for this line of code:
programmaticallyInstantiatedGraph.dataSource = self;
--> Assigning to 'id' from incompatible type 'ViewController * const__strong'

—
Reply to this email directly or view it on GitHub.

[kajensen]

thanks...lol

[michaelarmstrong]

Sorry i never got around to writing up a PR... seems you guys did it yourselves :D thanks. Fits in better into my architecture now without any workarounds :)

[Boris-Em]

Hi @michaelarmstrong,
Good to hear! Thank you for opening this issue.