Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy load parsers #118

Merged
merged 4 commits into from
Jul 17, 2018
Merged

Lazy load parsers #118

merged 4 commits into from
Jul 17, 2018

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Jul 16, 2018

Related issue: #117

  • Lazy require format specific parser
  • Allow to override the require method via options.

@Borewit
#117 Lazy load format specific parsers.
cd76d3f 
Allow to override the require method via options.
@coveralls
Copy link

coveralls commented Jul 16, 2018 •
edited
Loading

Coverage Status

Coverage increased (+1.03%) to 93.243% when pulling b212cac on lazy-load-parser into f700ca9 on master.

@Borewit Borewit mentioned this pull request Jul 17, 2018
Closed
14 tasks
@Borewit Borewit merged commit 8eabf2e into master Jul 17, 2018
@Borewit Borewit deleted the lazy-load-parser branch August 16, 2018 18:37
@Borewit Borewit mentioned this pull request Aug 17, 2018
Closed
@Borewit Borewit mentioned this pull request Jan 4, 2019
Merged
mikiymk referenced this pull request in mikiymk/music-metadata Sep 23, 2022
@mikiymk
Merge pull request #118 from mikiymk/only-parse-from-buffer
3b31e3c 
テストでFile, Buffer, Streamそれぞれでテストする
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Borewit @coveralls