Skip to content

Replace usage of int Margins with Size margins #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Replace usage of int Margins with Size margins #1739

wants to merge 3 commits into from

Conversation

@JohnMcGuinness
Copy link
Contributor

Partly addresses #1732

@JohnMcGuinness JohnMcGuinness mentioned this pull request Jun 19, 2020
Open
10 tasks
@JohnMcGuinness JohnMcGuinness linked an issue Jun 20, 2020 that may be closed by this pull request
Remove usage of deprecated APIs from the framework and examples #1732
Open
10 tasks
jonathanaustin
jonathanaustin requested changes Jun 24, 2020
View reviewed changes
Copy link
Member

@jonathanaustin jonathanaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good.

Could I make a request for some new unit tests as the tests are lacking on Margin for the deprecated Constructors and Methods. You could also change the WPanelRenderer_Test to stop using the deprecated constructors on Margin.

@JohnMcGuinness JohnMcGuinness deleted the remove-usage-of-Margin-int-sizing branch June 24, 2020 13:53
@JohnMcGuinness JohnMcGuinness restored the remove-usage-of-Margin-int-sizing branch June 24, 2020 14:00
@JohnMcGuinness JohnMcGuinness deleted the remove-usage-of-Margin-int-sizing branch June 24, 2020 22:49
@JohnMcGuinness JohnMcGuinness mentioned this pull request Jun 25, 2020
Merged
@JohnMcGuinness JohnMcGuinness removed a link to an issue Aug 29, 2021
Remove usage of deprecated APIs from the framework and examples #1732
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathanaustin jonathanaustin jonathanaustin requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JohnMcGuinness @jonathanaustin