Skip to content

Conversation

@JohnMcGuinness
Copy link
Contributor

Replaced usage of WHeading.TITLE and other constant based heading levels with HeadingLevel values.

@JohnMcGuinness JohnMcGuinness changed the title Ensure consistent usage of HeadinLevel Ensure consistent usage of HeadingLevel Jun 7, 2020
Copy link
Member

@jonathanaustin jonathanaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just made a request for some new unit tests for WHeading.

Merge branch 'georgie' into ensure-consistent-usage-of-HeadingLevel
@JohnMcGuinness JohnMcGuinness self-assigned this Jun 9, 2020
@JohnMcGuinness JohnMcGuinness requested review from jonathanaustin and removed request for jonathanaustin June 15, 2020 10:37
Copy link
Member

@jonathanaustin jonathanaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JohnMcGuinness JohnMcGuinness merged commit 27dd7d7 into BorderTech:georgie Jun 17, 2020
@JohnMcGuinness
Copy link
Contributor Author

Partly Addresses #1732

@JohnMcGuinness JohnMcGuinness linked an issue Jul 28, 2020 that may be closed by this pull request
10 tasks
@JohnMcGuinness JohnMcGuinness deleted the ensure-consistent-usage-of-HeadingLevel branch July 28, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove usage of deprecated APIs from the framework and examples

2 participants