fix: position error handling and type consistency #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Position Error Handling and Type Consistency
Changes Made
getPositionfunction that was silently returningundefinedPromise<GetPositionResponse>GetPositionResponseinterface to includetokenIdand match SDK typesWhy
The previous implementation was silently failing by returning
undefinedinstead of propagating errors. This made error handling more difficult for consumers of the function and made testing less reliable. The response type update ensures better type safety and consistency with the SDK.Testing
Impact
This change makes the position-related functions more predictable and consistent with the rest of the codebase's error handling patterns. The updated response type provides better type safety and developer experience.