fix: getQuote & add SlippageTolerance in buildSwapCallData #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor getQuote and buildSwapCallData to use Pool instance and add slippage
Overview
This PR refactors
getQuoteto use a Pool instance directly and adds slippage tolerance handling tobuildSwapCallData.Changes
getQuoteto accept Pool instance instead of individual parametersslippageToleranceparameter tobuildSwapCallDatawith default 0.5% (50 bps)getQuotewithbuildSwapCallDatafor automatic minimum output calculationTechnical Details
getQuotenow uses pool.poolKey directly instead of constructing itbuildSwapCallDatacalculates amountOutMin using slippage if not provided0x${string}formatTesting
Updated test suite to:
Usage Example