Skip to content

Conversation

@gabitoesmiapodo
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings October 17, 2025 20:15
@vercel
Copy link

vercel bot commented Oct 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cowswap Canceled Canceled Oct 17, 2025 9:27pm

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Sync i18n strings from Crowdin and adjust translations for new bridge and trade UI messages.

  • Add new bridge-related and countdown strings across locales
  • Move some keys to new file paths and re-activate previously deprecated keys
  • Fix incorrect English translation in en-US ("sell")

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
apps/cowswap-frontend/src/locales/ru-RU.po Adds new bridge and countdown messages; fixes a placeholder formatting; several new strings left untranslated.
apps/cowswap-frontend/src/locales/es-ES.po Adds new bridge and countdown messages; several new strings left untranslated.
apps/cowswap-frontend/src/locales/en-US.po Corrects translation of "sell" to English.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

msgstr "Заказ не может быть {statusText}. Ваша учетная запись запрещена в списке."

#: apps/cowswap-frontend/src/modules/bridge/pure/ProxyAccountBanner/index.tsx
msgid "The bridge provider modified the recipient address to <0/>. This ensure smooooth bridging."
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical error in the source string: 'This ensure' should be 'This ensures'. Please update the source text accordingly.

Suggested change
msgid "The bridge provider modified the recipient address to <0/>. This ensure smooooth bridging."
msgid "The bridge provider modified the recipient address to <0/>. This ensures smooooth bridging."

Copilot uses AI. Check for mistakes.
msgstr "La orden no puede ser {statusText}. Su cuenta está en la lista negada."

#: apps/cowswap-frontend/src/modules/bridge/pure/ProxyAccountBanner/index.tsx
msgid "The bridge provider modified the recipient address to <0/>. This ensure smooooth bridging."
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical error in the source string: 'This ensure' should be 'This ensures'. Please update the source text accordingly.

Suggested change
msgid "The bridge provider modified the recipient address to <0/>. This ensure smooooth bridging."
msgid "The bridge provider modified the recipient address to <0/>. This ensures smooooth bridging."

Copilot uses AI. Check for mistakes.
#: apps/cowswap-frontend/src/modules/twap/containers/TwapFormWidget/tooltips.tsx
msgid "The \"Part duration\" refers to the duration between each part of your TWAP order.<0/><1/>Choosing a shorter time allows for faster execution of each part, potentially reducing price fluctuations. Striking the right balance is crucial for optimal execution."
msgstr "\"Продолжительность части\" означает длительность между каждой частью вашего TWAP заказа. 0/><1/>Выбор более короткого времени позволяет быстрее выполнять каждую часть, потенциально уменьшая ценовые колебания."
msgstr "\"Продолжительность части\" означает длительность между каждой частью вашего TWAP заказа. <0/><1/>Выбор более короткого времени позволяет быстрее выполнять каждую часть, потенциально уменьшая ценовые колебания."
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Russian translation omits the final sentence ('Striking the right balance is crucial for optimal execution.'). Please append the missing sentence to keep the message complete. Suggested translation: "Достижение правильного баланса имеет решающее значение для оптимального исполнения."

Suggested change
msgstr "\"Продолжительность части\" означает длительность между каждой частью вашего TWAP заказа. <0/><1/>Выбор более короткого времени позволяет быстрее выполнять каждую часть, потенциально уменьшая ценовые колебания."
msgstr "\"Продолжительность части\" означает длительность между каждой частью вашего TWAP заказа. <0/><1/>Выбор более короткого времени позволяет быстрее выполнять каждую часть, потенциально уменьшая ценовые колебания. Достижение правильного баланса имеет решающее значение для оптимального исполнения."

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +230 to +231
msgid "The bridge provider modified the recipient address to <0/>. This ensure smooooth bridging."
msgstr "The bridge provider modified the recipient address to <0/>. This ensure smooooth bridging."
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical agreement: 'This ensure' should be 'This ensures'. Please update both msgid and msgstr.

Suggested change
msgid "The bridge provider modified the recipient address to <0/>. This ensure smooooth bridging."
msgstr "The bridge provider modified the recipient address to <0/>. This ensure smooooth bridging."
msgid "The bridge provider modified the recipient address to <0/>. This ensures smooooth bridging."
msgstr "The bridge provider modified the recipient address to <0/>. This ensures smooooth bridging."

Copilot uses AI. Check for mistakes.
#~ msgstr "Swap and Bridge"
#: apps/cowswap-frontend/src/modules/swap/hooks/useGetConfirmButtonLabel.ts
msgid "Swap and Bridge"
msgstr "Поменять местами"
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation omits 'Bridge'. Suggest translating the full action.

Suggested change
msgstr "Поменять местами"
msgstr "Обмен и мост"

Copilot uses AI. Check for mistakes.

#: apps/cowswap-frontend/src/modules/trade/pure/TradeConfirmation/CountDown.tsx
msgid "Quote refresh in"
msgstr "Цитировать обновление через"
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation uses the verb 'Цитировать' (to quote) instead of the financial term. Suggest a more accurate phrasing that composes well with '{value} сек'.

Suggested change
msgstr "Цитировать обновление через"
msgstr "Обновление котировки через"

Copilot uses AI. Check for mistakes.
#: apps/cowswap-frontend/src/modules/bridge/pure/RouteOverviewTitle/index.tsx
msgid "Your trade will be executed in 2 stops. First, you swap on <0>{COW_PROTOCOL_NAME} (Stop 1)</0>, then you bridge via <1>{providerInfoName} (Stop 2)</1>."
msgstr "Ваша сделка будет выполнена в 2 остановки. Во-первых, вы замените <0>{COW_PROTOCOL_NAME} (Stop 1)</0>, затем вы мостаетесь через <1>{providerInfoName} (Stop 2)</1>."
msgstr "Ваша сделка будет выполнена в 2 остановки. Во-первых, вы замените <0>{COW_PROTOCOL_NAME} (верхний 1)</0>, затем вы мостаетесь через <1>{providerInfoName} (верхний 2)</1>."
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term 'верхний' (upper) is incorrect for 'Stop'. Also 'вы замените' is misleading. Suggest a clearer and correct translation.

Suggested change
msgstr "Ваша сделка будет выполнена в 2 остановки. Во-первых, вы замените <0>{COW_PROTOCOL_NAME} (верхний 1)</0>, затем вы мостаетесь через <1>{providerInfoName} (верхний 2)</1>."
msgstr "Ваша сделка будет выполнена в 2 этапа. Сначала вы совершаете обмен на <0>{COW_PROTOCOL_NAME} (этап 1)</0>, затем вы осуществляете мост через <1>{providerInfoName} (этап 2)</1>."

Copilot uses AI. Check for mistakes.
#~ msgstr "Revoke {tokenSymbol} approval"
#: apps/cowswap-frontend/src/modules/erc20Approve/hooks/useApproveCallback.tsx
msgid "Revoke {tokenSymbol} approval"
msgstr "Revocar {tokenSymbol} aprobación"
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spanish grammar requires the article and 'de' for this construction.

Suggested change
msgstr "Revocar {tokenSymbol} aprobación"
msgstr "Revocar la aprobación de {tokenSymbol}"

Copilot uses AI. Check for mistakes.

#: apps/cowswap-frontend/src/modules/bridge/pure/ProxyAccountBanner/index.tsx
msgid "Swap bridged via your"
msgstr "Поменять местами мост через"
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation uses an imperative 'Поменять' and reads as an action, while the source is a label. Suggest a neutral phrasing that matches the source and composes with the following element.

Suggested change
msgstr "Поменять местами мост через"
msgstr "Своп, проведённый через ваш"

Copilot uses AI. Check for mistakes.
@gabitoesmiapodo gabitoesmiapodo merged commit 17e051b into feat/internationalization-setup-for-swap-cow-fi Oct 17, 2025
2 of 5 checks passed
@gabitoesmiapodo gabitoesmiapodo deleted the l10n_feat/internationalization-setup-for-swap-cow-fi branch October 17, 2025 21:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants