Skip to content

Conversation

@gabitoesmiapodo
Copy link
Collaborator

No description provided.

@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates localization files with new Crowdin translations for Russian and Spanish languages, while also reverting some changes in the English base file. The changes primarily involve reorganizing translation metadata and adding new translations for ERC20 approval functionality.

  • Updates Russian and Spanish locale files with new translations and metadata
  • Reverts some English locale changes, restoring original message locations
  • Adds new translation strings for order fillability warnings and ERC20 approval features

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
apps/cowswap-frontend/src/locales/ru-RU.po Adds new Russian translations for approval dialogs and order warnings, updates metadata
apps/cowswap-frontend/src/locales/es-ES.po Adds Spanish translation placeholders and updates metadata
apps/cowswap-frontend/src/locales/en-US.po Reverts message locations back to original file paths and removes obsolete entries

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

This comment was marked as outdated.

@gabitoesmiapodo gabitoesmiapodo merged commit 090b013 into feat/internationalization-setup-for-swap-cow-fi Aug 25, 2025
2 of 5 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates localization files with new translations from Crowdin for Russian and Spanish languages. The changes include new translated strings for token approval flows and order fillability warnings, along with metadata updates reflecting the latest translation revision dates.

  • Adds new translations for ERC-20 token approval functionality and user messaging
  • Updates metadata headers with latest revision dates from Crowdin (August 25, 2025)
  • Relocates some translation keys to reflect code restructuring in the application

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
apps/cowswap-frontend/src/locales/ru-RU.po Russian translations with new approval flow strings and updated metadata
apps/cowswap-frontend/src/locales/es-ES.po Spanish translations with new approval flow strings and updated metadata

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

msgid "Revoke {tokenSymbol} approval"
msgstr "Отозвать одобрение {tokenSymbol}"
#~ msgid "Revoke {tokenSymbol} approval"
#~ msgstr "Revoke {tokenSymbol} approval"
Copy link

Copilot AI Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The obsolete translation string should maintain the original Russian translation instead of reverting to English. It should be #~ msgstr \"Отозвать одобрение {tokenSymbol}\"

Suggested change
#~ msgstr "Revoke {tokenSymbol} approval"
#~ msgstr "Отозвать одобрение {tokenSymbol}"

Copilot uses AI. Check for mistakes.
msgid "Approve {tokenSymbol}"
msgstr "Утвердить {tokenSymbol}"
#~ msgid "Approve {tokenSymbol}"
#~ msgstr "Approve {tokenSymbol}"
Copy link

Copilot AI Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The obsolete translation string should maintain the original Russian translation instead of reverting to English. It should be #~ msgstr \"Утвердить {tokenSymbol}\"

Suggested change
#~ msgstr "Approve {tokenSymbol}"
#~ msgstr "Утвердить {tokenSymbol}"

Copilot uses AI. Check for mistakes.
msgid "Revoke {tokenSymbol} approval"
msgstr "Revocar {tokenSymbol} aprobación"
#~ msgid "Revoke {tokenSymbol} approval"
#~ msgstr "Revoke {tokenSymbol} approval"
Copy link

Copilot AI Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The obsolete translation string should maintain the original Spanish translation instead of reverting to English. It should be #~ msgstr \"Revocar {tokenSymbol} aprobación\"

Suggested change
#~ msgstr "Revoke {tokenSymbol} approval"
#~ msgstr "Revocar {tokenSymbol} aprobación"

Copilot uses AI. Check for mistakes.
msgid "Approve {tokenSymbol}"
msgstr "Aprobar {tokenSymbol}"
#~ msgid "Approve {tokenSymbol}"
#~ msgstr "Approve {tokenSymbol}"
Copy link

Copilot AI Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The obsolete translation string should maintain the original Spanish translation instead of reverting to English. It should be #~ msgstr \"Aprobar {tokenSymbol}\"

Suggested change
#~ msgstr "Approve {tokenSymbol}"
#~ msgstr "Aprobar {tokenSymbol}"

Copilot uses AI. Check for mistakes.
@gabitoesmiapodo gabitoesmiapodo deleted the l10n_feat/internationalization-setup-for-swap-cow-fi branch August 25, 2025 20:40
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants