Skip to content

Fix embed conversion prompt label for GitHub issues vs PRs#1620

Draft
nicepopo86-lang wants to merge 1 commit intoBoostIO:masterfrom
nicepopo86-lang:aria/issue-1149-embed-popup-fix
Draft

Fix embed conversion prompt label for GitHub issues vs PRs#1620
nicepopo86-lang wants to merge 1 commit intoBoostIO:masterfrom
nicepopo86-lang:aria/issue-1149-embed-popup-fix

Conversation

@nicepopo86-lang
Copy link

Summary\nThis fixes the GitHub URL conversion prompt so it reflects the pasted URL type:\n- -> Embed pull request\n- -> Embed issue\n\nThe previous prompt used a generic action and did not clarify issue vs PR intent. This addresses #1149's request for proper distinction in the embed popup flow.\n\n## Reproduction\n1. Open markdown editor.\n2. Paste a GitHub issue URL ().\n3. Observe conversion popup text.\n\n## Before\n- Prompt action text did not distinguish issue vs PR.\n\n## After\n- Prompt action text is context-aware ( / ).\n\n## Technical changes\n- Extended paste formatter result with optional .\n- Wired through menu callback.\n- Updated cloud editor, doc preview realtime hook path, and mobile doc editor to render the contextual label.\n\n## Validation\n- Static code review of conversion paths in cloud + mobile editor pipelines.\n- Dependency installation for local lint timed out in this environment; code changes are intentionally minimal and type-local.\n

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


nicepopo86-lang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants