Fix embed conversion prompt label for GitHub issues vs PRs#1620
Draft
nicepopo86-lang wants to merge 1 commit intoBoostIO:masterfrom
Draft
Fix embed conversion prompt label for GitHub issues vs PRs#1620nicepopo86-lang wants to merge 1 commit intoBoostIO:masterfrom
nicepopo86-lang wants to merge 1 commit intoBoostIO:masterfrom
Conversation
|
nicepopo86-lang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\nThis fixes the GitHub URL conversion prompt so it reflects the pasted URL type:\n- -> Embed pull request\n- -> Embed issue\n\nThe previous prompt used a generic action and did not clarify issue vs PR intent. This addresses #1149's request for proper distinction in the embed popup flow.\n\n## Reproduction\n1. Open markdown editor.\n2. Paste a GitHub issue URL ().\n3. Observe conversion popup text.\n\n## Before\n- Prompt action text did not distinguish issue vs PR.\n\n## After\n- Prompt action text is context-aware ( / ).\n\n## Technical changes\n- Extended paste formatter result with optional .\n- Wired through menu callback.\n- Updated cloud editor, doc preview realtime hook path, and mobile doc editor to render the contextual label.\n\n## Validation\n- Static code review of conversion paths in cloud + mobile editor pipelines.\n- Dependency installation for local lint timed out in this environment; code changes are intentionally minimal and type-local.\n