Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FXAA algorithm #185

Merged
merged 11 commits into from
May 20, 2022
Merged

Implement FXAA algorithm #185

merged 11 commits into from
May 20, 2022

Conversation

jiangdunchun
Copy link
Contributor

实现fxaa算法

@HanetakaChou
Copy link
Contributor

THe “VK_DEPENDENCY_BY_REGION_BIT” inside the “fxaa_pass_depend_on_color_grading_pass.dependencyFlags = VK_DEPENDENCY_BY_REGION_BIT” should be removed, since we use "sampled image" rather than "input attachment".

remove “fxaa_pass_depend_on_color_grading_pass.dependencyFlags = VK_DEPENDENCY_BY_REGION_BIT” from the YuqiaoZhang's comment
@jiangdunchun
Copy link
Contributor Author

jiangdunchun commented May 18, 2022

OK, I have fixed the "VK_DEPENDENCY_BY_REGION_BIT" problem and push a new commitment, @YuqiaoZhang please rerun the workflows

@huandzh
Copy link
Contributor

huandzh commented May 19, 2022

This PR implemented a new subpass, which is actually required by part C of the homework 2 - Add a new post-processing pass.

If I may give some advice, I recommend keep the engine with less features, but simpler and faster.

A feature/homework gallery page may be sufficient. Contributors can keep their work in own forks and display links in the page.

@huandzh
Copy link
Contributor

huandzh commented May 19, 2022

Are there any performance impacts when adding VK_IMAGE_USAGE_SAMPLED_BIT flag to all buffers?

@HanetakaChou
Copy link
Contributor

Are there any performance impacts when adding VK_IMAGE_USAGE_SAMPLED_BIT flag to all buffers?

I agree with you, "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT" should NOT be removed. Another backup buffer should be created.

@jiangdunchun
Copy link
Contributor Author

jiangdunchun commented May 19, 2022

This PR implemented a new subpass, which is actually required by part C of the homework 2 - Add a new post-processing pass.

If I may give some advice, I recommend keep the engine with less features, but simpler and faster.

A feature/homework gallery page may be sufficient. Contributors can keep their work in own forks and display links in the page.

well, i think FXAA is a meaningful feature for the purpose of game engine study.

@jiangdunchun
Copy link
Contributor Author

jiangdunchun commented May 19, 2022

Are there any performance impacts when adding VK_IMAGE_USAGE_SAMPLED_BIT flag to all buffers?

I agree with you, "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT" should NOT be removed. Another backup buffer should be created.

To the performance impacts of removing "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT", i will create a new buffer to do the FXAA pass. @YuqiaoZhang , is that OK?

@HanetakaChou
Copy link
Contributor

Are there any performance impacts when adding VK_IMAGE_USAGE_SAMPLED_BIT flag to all buffers?

I agree with you, "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT" should NOT be removed. Another backup buffer should be created.

To the performance impacts of removing "VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT", i will create a new buffer to do the FXAA pass. @YuqiaoZhang , is that OK?

Definitely! This buffer may be used by other post processing effects, for which the input attachment is NOT enough, such as SSAO. Perhaps two buffers (odd and even) should be created.

@jiangdunchun
Copy link
Contributor Author

jiangdunchun commented May 19, 2022

Definitely! This buffer may be used by other post processing effects, for which the input attachment is NOT enough, such as SSAO. Perhaps two buffers (odd and even) should be created.

I have made a new commitment for creating two buffers for post processing effects, and using one of them for FXAA. @YuqiaoZhang please review the code and assess if this feature should be accepted.

@hyv1001 hyv1001 changed the title Fxaa Implement FXAA algorithm May 20, 2022
@hyv1001 hyv1001 merged commit 44e407e into BoomingTech:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants