Skip to content

Review of #5429, OIDC avatar fetching #5626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 24, 2025

Conversation

ssddanbrown
Copy link
Member

@ssddanbrown ssddanbrown commented May 24, 2025

Continuation/review of PR #5429

Doc Updates

  • Document added option in ldap docs
    • Ensure behaviour (login where no existing avatar set) and security issues (SSR) are clearly mentioned.

@ssddanbrown ssddanbrown added this to the Next Feature Release milestone May 24, 2025
@ssddanbrown ssddanbrown self-assigned this May 24, 2025
But only where the user does not already have an avatar assigned.
This aligns with the LDAP avatar fetching logic.
@ssddanbrown ssddanbrown changed the title Review of #5429 Review of #5429, OIDC avatar fetching May 24, 2025
Up to 3 times.
Can be needed based upon testing with Auth0.
Should be fine as long as it's something clearly documented.
Added test to cover.
@ssddanbrown ssddanbrown merged commit d149b80 into development May 24, 2025
16 of 17 checks passed
@ssddanbrown ssddanbrown deleted the rubentalstra-development branch May 24, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant