Added support for concatenating multiple LDAP attributes in displayName - #5295
Merged
ssddanbrown merged 2 commits intoDec 1, 2024
Merged
Conversation
ssddanbrown
added a commit
that referenced
this pull request
Dec 1, 2024
Review of #5295 Added test to cover functionality. Moved splitting from config to service.
Member
|
Thanks again for providing this @MatthieuLeboeuf! Not certain what test was originally failing for you, but it might have been due to the ordering being changed via the merge of attributes when pulling back user data, which would have meant (after filtering away of a null thumbnail attribute) that the display name attribution in the test would be at a different index to what's expected. This will be part of the next feature release. Docs Updates
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
To resolve #1684 and the next of #5288
I've made the requested changes, but I can't seem to fix the test error. Do you have any ideas ?