Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment WYSIWYG Inputs #4815

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Comment WYSIWYG Inputs #4815

merged 6 commits into from
Jan 31, 2024

Conversation

ssddanbrown
Copy link
Member

@ssddanbrown ssddanbrown commented Jan 30, 2024 •
edited
Loading

This PR aims to bring the recently added simple book/chapter/shelf description WYSIWYG inputs to comments.

Todo

  • Added WYSWIYG loading and UI for comments.
  • Add back-end changes for submission/saving.
  • Add link selector support.
  • Load in WYSWIYG content gracefully where possible.
  • Remove old redundant comment regen command.
  • Add HTML cleaning on comment show/usage?
  • Set issue to drop old text (markdown) comment column in a future update?
  • Testing
    • RTL
    • Dark mode
    • Update tests not to use Comment->text property.
    • Test editor loads if cannot comment all, but can edit existing comment.
    • Test display of comments
    • Test updating of comments with HTML
    • Test HTML content filtering on submit

Doc Updates

  • Update advisory about limited compatibility with old markdown content.
  • Update advisory on removal of the comment regen command.
  • Remove docs content for comment regen command.

@ssddanbrown
Comments: Added input wysiwyg for creating/updating comments
5c92b72 
Not supporting old content, existing HTML or updating yet.
@ssddanbrown ssddanbrown added this to the Next Feature Release milestone Jan 30, 2024
@ssddanbrown ssddanbrown self-assigned this Jan 30, 2024
@ssddanbrown
Comments: Added back-end HTML support, fixed editor focus
adf0bae 
Also fixed handling of editors when moved in DOM, to properly remove
then re-init before & after move to avoid issues.
@ssddanbrown
Comments: Added wysiwyg link selector, updated tests, removed command
e9a19d5 
- Updated existing tests with recent back-end changes, mainly to use
  HTML data.
- Removed old comment regen command that's no longer required.
@ssddanbrown
Comments: Added HTML filter on load, tinymce elem filtering
06901b8 
- Added filter on load to help prevent potentially dangerous comment
  HTML in DB at load time (if it gets passed input filtering, or is
  existing).
- Added TinyMCE valid_elements for input wysiwygs, to gracefully degrade
  content at point of user-view, rather than surprising the user by
  stripping content, which TinyMCE would show, post-save.
@ssddanbrown ssddanbrown mentioned this pull request Jan 31, 2024
Open
@ssddanbrown ssddanbrown merged commit 16af833 into development Jan 31, 2024
17 of 22 checks passed
@ssddanbrown ssddanbrown deleted the comment_wysiwyg branch January 31, 2024 16:57
This was referenced Jan 31, 2024
Closed
Closed
@kernelry
Copy link

Will be possible to insert an image in WYSIWYG comment editor? 😁
similar to the old markdown Comment editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ssddanbrown ssddanbrown

Labels
📖 Docs Update 💻 Front-End 🏭 Back-End 🛠️ Enhancement
Milestone
v24.02
Development

Successfully merging this pull request may close these issues.
2 participants
@ssddanbrown @kernelry