Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better application color scheme control #4002

Merged
merged 8 commits into from
Jan 28, 2023
Merged

Conversation

ssddanbrown
Copy link
Member

@ssddanbrown ssddanbrown commented Jan 28, 2023

Addition of dark-mode-specific color options, in addition to splitting out link colors from primary app color.
For #3910 and #2314

TODO

  • - Update tabs to be tagged for accessibility.
  • - Update css to use link color.
  • - Update color handling to use dark colors.
  • - Active dark/light mode on tab press for preview?
  • - Set defaults for dark colors.
  • - Migrate existing light settings to dark settings for upgrade stability.
  • - Test across light and dark mode.

Also added link color option, not yet used.
Cleaned up tabbed interface control design as part of this.
Added use of more accessible tags to create tabbed-interfaces then
updated css and JS to require use of those attributes rather than custom
techniques.

Updated relevant parts of app.
Some custom parts using their own tabs though, something to improve in
future.
Updated export to use link color for link.
Export will now copy primary color to link color options for stable
upgrades.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant