Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Reordering attachments breaks ability to drag attachment link into edited page #591

Closed
Wookbert opened this issue Nov 12, 2017 · 3 comments

Comments

@Wookbert
Copy link

Wookbert commented Nov 12, 2017

  • BookStack Version 0.18 (on Demo Site)
  • Observed on Mac OS High Sierra 10.13.1, Chrome Version 62.0.3202.89

In Edit mode: Dragging an attachment into the page, creates link in the current paragraph to that attachment. So far, so good...

However: If one grabs the reorder attachments icon and moves it to reorder (regardless whether there is one or multiple attachments), dragging the attachment itself into the page is no longer possible. In other words: Reordering breaks the ability to drag the attachment link into the page.

Workaround: Save the page first, then enter Edit mode again, and dragging attachment to create link works again.

Video with bug in screen recording session:
https://www.youtube.com/watch?v=_N78tA0eq2k

@Wookbert Wookbert changed the title Bug: Reordering attachments breaks the ability to drag the attachment link into the page. Bug: Reordering attachments breaks ability to drag attachment link into edited page Nov 12, 2017
@ssddanbrown
Copy link
Member

Thank for reporting but I must admit, Did not even realise this was possible.

Will have a look as to how/why this occurs.

@Wookbert
Copy link
Author

Wookbert commented Nov 19, 2017 via email

ssddanbrown added a commit that referenced this issue May 22, 2023
Enables easier sorting and dragging of box into content.
Related to #591
@ssddanbrown ssddanbrown added this to the v23.05.2 milestone May 22, 2023
@ssddanbrown
Copy link
Member

Apologies for the lack of response on this one for the past half a decade 😨
Just came across this while reviewing outstanding bugs.

At some point I did add proper dedicated drag and drop handling via dragging using the handle, and via a button on the attachment card.
Coming back to this now, I've extended the drag and drop handling so that the link/name of the attachment is also a drag "handle" so drop usage as per your video would now be managed via our dedicated handling.
I added that in e591f48, and it will be part of the next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants