Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling of hyperlinks in content relies on color only (a11y) #4939

Closed
JocelynDelalande opened this issue Apr 10, 2024 · 4 comments
Closed

Styling of hyperlinks in content relies on color only (a11y) #4939

JocelynDelalande opened this issue Apr 10, 2024 · 4 comments

Comments

@JocelynDelalande
Copy link

Describe the Bug

In default style, hyperlinks are distinguishable from regular text only by color, which is not enough and problematic from an accessibility standpoint (think colorblind).

Note that in info boxes, there is underlining on links.

Underlining on hover is not enough.

image

Steps to Reproduce

image

Expected Behaviour

underline links in content column.

Screenshots or Additional Context

Workaround (as bookstack admin)

Add a <style> tag in Settings / Customization with the following content:

#tinymce main.content-wrap.card a,
 .page-content a {
 text-decoration: underline;
}

Browser Details

No response

Exact BookStack Version

v23.08.3

@ssddanbrown
Copy link
Member

Thanks @JocelynDelalande, sounds like a sensible improvement to make, have assigned it to the next feature release.

Dev Notes

  • Check various scenarios with linked non-text content (including variations with mixed non-text/text), across browsers.

Doc Upates

  • Upgrade notice regarding change to default content link styles, since this could be a significant change to user content.

@szabeszg
Copy link

After installing BookStack for the very fist time, my first style addition was to add underlines to links, so it is a welcome change for sure!

ssddanbrown added a commit that referenced this issue Apr 13, 2024
Inline with A11y recommendations where color may not be reliable on its
own.
Tested various content link scenarios across chrome, safari & FF.
For #4939
@ssddanbrown
Copy link
Member

I've now addressed this in content via 0f6cb9e, to be part of the next feature release.
There are various sceanrios where we also have links in the UI itself, although many of those can be context specific and not where underlines may be productive (or they already have other hints to a link), but those areas can be addressed as needed based upon feedback and/or improvement as areas evolve.

@JocelynDelalande
Copy link
Author

Excellent, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants