Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translatation is missing for specific notifications in webhooks #4216

Closed
Android1338 opened this issue May 3, 2023 · 1 comment
Closed

Translatation is missing for specific notifications in webhooks #4216

Android1338 opened this issue May 3, 2023 · 1 comment
Labels
🏭 Back-End 🔨 Feature Request
Milestone
v23.06

Comments

@Android1338
Copy link

Describe the Bug

I'm using a Discord server with a few channels for BookStack notifications only and if I restore a revision in BookStack, I just receive the following message:
Julian activities.revision_restore

The same happens if I change admin settings in BookStack:
Julian activities.settings_update

Also if a maintenance has been started:
Julian activities.maintenance_action_run

Steps to Reproduce

  1. Use "German" as language
  2. Create a webhook, in my example for Discord
  3. Make some changes in BookStack to receive alerts via Discord
  4. Switch to Discord and you'll see non-translated messages

Expected Behaviour

I expected translated messages like ...

  • Julian started a maintenance
  • Julian restored a page

Screenshots or Additional Context

bug

Browser Details

Firefox 112.0.2 (64-Bit) on Windows 10

Exact BookStack Version

v23.05

PHP Version

8.1.2

Hosting Environment

Ubuntu 22.04.2 LTS VPS, installed using official installation script
@Android1338 Android1338 changed the title Translatation is missing for specific webhooks Translatation is missing for specific notifications in webhooks May 3, 2023
@ssddanbrown ssddanbrown added this to the Next Feature Release milestone May 7, 2023
ssddanbrown added a commit that referenced this issue Jun 12, 2023
@ssddanbrown
Added activity text for each activity type
f39938c 
Ensures some sensible text is always in webhook text data.
Also aligned some notification reporting to use centralised activity
system instead of custom success events.

For #4216
@ssddanbrown
Copy link
Member

Thanks for reporting.
I've now added activity text for each activity type within commit f39938c.
This will be part of the next feature release.
Might take a little extra time for language variations to trickle down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏭 Back-End 🔨 Feature Request
Milestone
v23.06
Development

No branches or pull requests
2 participants
@ssddanbrown @Android1338