Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HEIC Support #2505

Open
dannyhanes opened this issue Jan 22, 2021 · 3 comments
Open

HEIC Support #2505

dannyhanes opened this issue Jan 22, 2021 · 3 comments

Comments

@dannyhanes
Copy link

Describe the feature you'd like
Add support for HEIC images

Describe the benefits this feature would bring to BookStack users
Not sure how many users run into this, but before I can upload photos to Bookstack, I would need to convert them to a compatible format. This would just allow for easier uploading of iPhone images.

@ssddanbrown
Copy link
Member

Thanks for the request @dannyhanes, (And also thanks for the support via sponsor!),

Ideally, to be supported, we'd need our image resizing library to support these files otherwise it'll be tricky to be able to display these in the gallery or auto-create reduced sized versions for page content.

In addition, It seems that general support for the file format is still pretty weak with it potentially dependant on people having installed system extensions/packages to support the format. It's a similar case with AVIF although that may some sooner thanks to its openess.

I seem to remember something about iOS auto-converting files to jpeg upon upload to web? Apple page lightly mentions something along these lines. Might have to power up the old iPhone SE and have a play.

@dannyhanes
Copy link
Author

@ssddanbrown Yeah, when I put the request in, I kinda figured with it being new'ish and generally an Apple only feature, that it would probably be low on the list. I just noticed it when I went to upload some photos and thought at the very least I could make a request.

And I am glad I am able to support Bookstack. :) Honestly, it is probably the most used self-hosted app in my house. Keep up the great work!

@ssddanbrown
Copy link
Member

Just checking in on this, Kinda also tracking AVIF as part of this since it's a similar situation (And since they're somewhat related via HEIF).

AVIF

  • System: Looks to now be supported to some level, although potentially only on PHP 8.1 and greater.
  • Browser: Support has improved, although Safari dragging everyone back.

HEIC

Thoughts

AVIF is coming along quite nicely although PHP 8.1 support requirement will be a restriction. I'm thinking early/mid next year would be a good point to add support (Since 8.1 would have been out leaving PHP and browser support to mature a little).

HEIC isn't really viable, especially for our use where the image system is primarily for images to be visible within content and the gallery. Think it's going to be a while (Range of years potentially) before we see viability here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants