EXIF data is ignored when uploading images

[JetUni]

Describe the bug
When inserting an image that has EXIF rotation data, the rotation of the image isn't respected in the output.

Steps To Reproduce
Steps to reproduce the behavior:

1. Upload an image with EXIF rotation data
2. Insert into the page
3. See error in preview

Expected behavior
The EXIF rotation data should be considered when uploading the image so that it will display correctly

Screenshots

Your Configuration (please complete the following information):

• Exact BookStack Version (Found in settings): 0.27.4
• PHP Version: PHP 7.0.33-0ubuntu0.16.04.9
• Hosting Method (Nginx/Apache/Docker): Nginx

[alexmannuk]

I've tested this on my own setup with v0.29.3 using Apache on Ubuntu 18.04 with PHP 7.2.24 and images appear to display rotated correctly. Either this is fixed in later versions of BookStack or you need to make sure php-exif is installed on your web server.

[cod3monk]

I encountered the same problem running v21.12.1 using the latest solidnerd/bookstack docker image.

As the docker container does not install the exif php extension (explicitly), I have installed it manually and it did not make any change on reuploaded files. Same for mbstring.

Example

Page where image is used: link (may have changed in the meantime)
Original file: link (with correct rotation included in EXIF data)
Scaled file: link (missing all EXIF data, including rotation)

Expected Behavior

Either

• preserve exif rotational information or
• rotate scaled image according to exif information.

Related

Intervention/image#886

[ssddanbrown]

Thanks @cod3monk.

Sounds like we should call orientate in our thumbnail generation chain to alter the image to match exif rotation.

Will assign to next feature release to check, and implement this route if found viable.

[ssddanbrown]

Okay, not as simple as hoped.

By the time the intervention image instance has been created from image data the orientation exif is lost. Happens when creating and export an image via gd in general. Not a simple thing to patch upstream either unfortunately.

Instead we'll likely have to manually convert the image data to a stream on our side then read the exif_read_data output and then copy Intervention's orientate logic to achieve the desired output.

[ssddanbrown]

If have now applied 55d61fc which re-implements intervention's orientation based upon exif data from original image data.

This will be part of the next feature release so I'll therefore close this off.

[EricChen1248]

Just leaving a comment for users who are stupid like me and still find it not working.

If you are using linuxserver.io's version of bookstack, you need to create a custom docker image off of it and add php8-exif, as this fix relies on that.

FROM lscr.io/linuxserver/bookstack:latest

RUN apk add php8-exif

It's likely the same for solidnerd's version, but I didn't test it.

[Skillkiller]

Just leaving a comment for users who are stupid like me and still find it not working.

If you are using linuxserver.io's version of bookstack, you need to create a custom docker image off of it and add php8-exif, as this fix relies on that.

Fixed by linuxserver/docker-bookstack@248b876