Adgudime/apex sac #32

AdityaGudimella · 2020-08-24T19:58:09Z

Why are these changes needed?

Fixed a bug in action shape calculation
Tuned hyperparameters for tests. Pendulum now converges successfully.

I've run scripts/format.sh to lint the changes in this PR.
I've included any doc changes needed for https://docs.ray.io/en/latest/.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
Testing Strategy
- Unit tests
- Release tests
- This PR is not tested (please justify below)

Edilmo

This looks good to me but we have to change the target branch to releases/0.8.6
I will approve after that.

AdityaGudimella added 2 commits August 19, 2020 14:41

Updated params for Pendulum

10d630e

Tuned hyperparams for ApexSAC

150f9ea

AdityaGudimella self-assigned this Aug 24, 2020

AdityaGudimella requested a review from Edilmo August 24, 2020 19:58

Edilmo reviewed Aug 24, 2020

View reviewed changes

Merge branch 'releases/0.8.5' into adgudime/apex_sac

703f544

AdityaGudimella changed the base branch from releases/0.8.5 to releases/0.8.6 August 24, 2020 21:06

AdityaGudimella changed the base branch from releases/0.8.6 to releases/0.8.5 August 24, 2020 21:10