Syncing with upstream master 2020-07-30

.bazelrc

@@ -1,51 +1,63 @@
 # Must be first. Enables build:windows, build:linux, build:macos, build:freebsd, build:openbsd
 build --enable_platform_specific_config
 ###############################################################################
-# On       Windows, provide: USE_CLANG_CL=1, CC=clang, BAZEL_LLVM, BAZEL_SH
-# On all platforms, provide: PYTHON2_BIN_PATH, PYTHON3_BIN_PATH
+# On       Windows, provide: BAZEL_SH, and BAZEL_LLVM (if using clang-cl)
+# On all platforms, provide: PYTHON3_BIN_PATH=python
 ###############################################################################
 build --action_env=PATH
-build:linux   --compilation_mode=opt
-build:macos   --compilation_mode=opt
-build:windows --compilation_mode=fastbuild
+# For --compilation_mode=dbg, consider enabling checks in the standard library as well (below).
+build --compilation_mode=opt
+build --experimental_ui_deduplicate
 # This workaround is needed to prevent Bazel from compiling the same file twice (once PIC and once not).
 build:linux --force_pic
 build:macos --force_pic
+build:clang-cl --compiler=clang-cl
+build:msvc --compiler=msvc-cl
+# This is needed for some core tests to run correctly
+test:windows --enable_runfiles
 # TODO(mehrdadn): Revert the "-\\.(asm|S)$" exclusion when this Bazel bug
 #                 for compiling assembly files is fixed on Windows:
 #                 https://github.com/bazelbuild/bazel/issues/8924
 # Warnings should be errors
-build --per_file_copt="-\\.(asm|S)$,-.*/arrow/util/logging\\.cc@-Werror"
+build:linux    --per_file_copt="-\\.(asm|S)$@-Werror"
+build:macos    --per_file_copt="-\\.(asm|S)$@-Werror"
+build:clang-cl --per_file_copt="-\\.(asm|S)$@-Werror"
+build:msvc     --per_file_copt="-\\.(asm|S)$@-WX"
 # Ignore warnings for protobuf generated files and external projects.
-build --per_file_copt="-\\.(asm|S)$,\\.pb\\.cc$@-w"
+build --per_file_copt="\\.pb\\.cc$@-w"
 build --per_file_copt="-\\.(asm|S)$,external/.*@-w"
-# Ignore this warning since it's impractical to fix in the relevant headers
-build --per_file_copt="-\\.(asm|S)$,.*/ray/raylet/reconstruction_policy_test\\.cc@-Wno-inconsistent-missing-override"
-# Ignore this warning since CPython and Cython have issue removing deprecated tp_print on MacOS
-build --per_file_copt="-\\.(asm|S)$,.*/_raylet\\.cpp@-Wno-deprecated-declarations"
-build --per_file_copt="-\\.(asm|S)$,.*/_streaming\\.cpp@-Wno-deprecated-declarations"
 # Ignore minor warnings for host tools, which we generally can't control
-build --host_copt="-Wno-builtin-macro-redefined"
-build --host_copt="-Wno-inconsistent-missing-override"
-build --host_copt="-Wno-microsoft-unqualified-friend"
+build:clang-cl --host_copt="-Wno-inconsistent-missing-override"
+build:clang-cl --host_copt="-Wno-microsoft-unqualified-friend"
 # This workaround is needed due to https://github.com/bazelbuild/bazel/issues/4341
 build --per_file_copt="-\\.(asm|S)$,external/com_github_grpc_grpc/.*@-DGRPC_BAZEL_BUILD"
+# Don't generate warnings about kernel features we don't need https://github.com/ray-project/ray/issues/6832
+build:linux --per_file_copt="-\\.(asm|S)$,external/com_github_grpc_grpc/.*@-DGPR_MANYLINUX1"
+# Ignore wchar_t -> char conversion warning on MSVC
+build:msvc --per_file_copt="external/boost/libs/regex/src/wc_regex_traits\\.cpp@-wd4244"
 build --http_timeout_scaling=5.0
+build --verbose_failures
 build:iwyu --experimental_action_listener=//:iwyu_cpp
 
 # Print relative paths when possible
 build:windows --attempt_to_print_relative_paths
 # Save disk space by hardlinking cache hits instead of copying
 build:windows --experimental_repository_cache_hardlinks
-# Avoid duplicate noise in the build output
-build:windows --experimental_ui_deduplicate
 # Clean the environment before building, to make builds more deterministic
 build:windows --incompatible_strict_action_env
 # For colored output (seems necessary on Windows)
 build:windows --color=yes
 # For compiler colored output (seems necessary on Windows)
-build:windows --per_file_copt="-\\.(asm|S)$@-fansi-escape-codes"
-build:windows --per_file_copt="-\\.(asm|S)$@-fcolor-diagnostics"
+build:clang-cl --per_file_copt="-\\.(asm|S)$@-fansi-escape-codes"
+build:clang-cl --per_file_copt="-\\.(asm|S)$@-fcolor-diagnostics"
+
+# Debug build flags. Uncomment in '-c dbg' builds to enable checks in the C++ standard library:
+#build:linux --cxxopt="-D_GLIBCXX_DEBUG=1"
+#build:linux --cxxopt="-D_GLIBCXX_DEBUG_PEDANTIC=1"
+#build:linux --cxxopt="-D_LIBCPP_DEBUG=1"
+#build:macos --cxxopt="-D_GLIBCXX_DEBUG=1"
+#build:macos --cxxopt="-D_GLIBCXX_DEBUG_PEDANTIC=1"
+#build:windows --cxxopt="-D_ITERATOR_DEBUG_LEVEL=2"
 
 # Thread sanitizer configuration:
 build:tsan --strip=never
@@ -55,16 +67,47 @@ build:tsan --copt -g
 build:tsan --copt -fno-omit-frame-pointer
 build:tsan --linkopt -fsanitize=thread
 
-test:ci --flaky_test_attempts=3
+# Memory sanitizer configuration
+build:asan --strip=never
+build:asan --copt -g
+build:asan --copt -fsanitize=address
+build:asan --copt -DADDRESS_SANITIZER
+build:asan --copt -fno-omit-frame-pointer
+build:asan --linkopt -fsanitize=address
+test:asan --jobs=1
+test:asan --test_env=ASAN_OPTIONS="detect_leaks=0"
+# This LD_PRELOAD is set for Travis. You will need to change it for local debugging.
+test:asan --test_env=LD_PRELOAD="/usr/lib/x86_64-linux-gnu/libasan.so.2 /usr/lib/gcc/x86_64-linux-gnu/7/libasan.so"
+# For example, for Ubuntu 18.04 libasan can be found here:
+# test:asan --test_env=LD_PRELOAD="/usr/lib/gcc/x86_64-linux-gnu/7/libasan.so"
+
+# CI configuration:
+aquery:ci --color=no
+aquery:ci --noshow_progress
+build:ci --color=yes
+build:ci --curses=no
+build:ci --disk_cache=~/ray-bazel-cache
+build:ci --remote_cache="https://storage.googleapis.com/ray-bazel-cache"
+build:ci --progress_report_interval=100
+build:ci --show_progress_rate_limit=15
+build:ci --show_task_finish
+build:ci --ui_actions_shown=1024
+build:ci-travis --show_timestamps  # Travis doesn't have an option to show timestamps, but GitHub Actions does
+# GitHub Actions has low disk space, so prefer hardlinks there.
+build:ci-github --experimental_repository_cache_hardlinks
+test:ci --flaky_test_attempts=5
 test:ci --nocache_test_results
-test:ci --progress_report_interval=100
-test:ci --show_progress_rate_limit=100
-test:ci --show_timestamps
 test:ci --spawn_strategy=local
 test:ci --test_output=errors
 test:ci --test_verbose_timeout_warnings
+test:ci --test_env=RAY_GCS_ACTOR_SERVICE_ENABLED
+
+aquery:get-toolchain --include_commandline=false
+aquery:get-toolchain --noimplicit_deps
 
-# [Linux] Uncomment this line to print a stack trace on exit.
-#test:linux --run_under="bash -c 'if command -v strace >/dev/null && strace -qq -k -e exit true 2>/dev/null; then strace -qq -k -e exit -e trace=\"!all\" -s 32768 -f -o >(awk \"/^[0-9]+ / { y = \\$3 != \\\"SIGCHLD\\\" && \\$3 != \\\"SIGTERM\\\" && \\$5 != \\\"SIGTERM\\\" && \\$5 != \\\"SIGKILL2\\\"; } y { print; }\" 1>&2 && cat 1>&2) -- \"$@\"; else \"$@\"; fi' -"
-# [Linux] Uncomment this line to preload libSegFault.so if available, to print a stack trace on aborts and segfault. (Note: This doesn't always work.)
-#test:linux --run_under="bash -c 'unset GREP_OPTIONS && if ! grep -q -o Microsoft /proc/version 2>/dev/null; then libs=\"$(command -v ldconfig >/dev/null && ldconfig -p | grep -F -o -e \"libSegFault.so\" | uniq | tr \"\\\\n\" :)\" && if [ -n \"${libs%:}\" ]; then export SEGFAULT_SIGNALS=\"abrt segv\" LD_PRELOAD=\"${libs}${LD_PRELOAD-}\"; fi; fi && \"$@\"' -"
+# [Linux] Uncomment this line (or use --config) to print a stack trace on exit.
+#test:linux --config=strace
+test:strace --run_under="bash -c 'if command -v strace >/dev/null && strace -qq -k -e exit true 2>/dev/null; then strace -qq -k -e exit -e trace=\"!all\" -s 32768 -f -o >(awk \"/^[0-9]+ / { y = \\$3 != \\\"SIGCHLD\\\" && \\$3 != \\\"SIGTERM\\\" && \\$5 != \\\"SIGTERM\\\" && \\$5 != \\\"SIGKILL2\\\"; } y { print; }\" 1>&2 && cat 1>&2) -- \"$@\"; else \"$@\"; fi' -"
+# [Linux] Uncomment this line (or use --config) to preload libSegFault.so if available, to print a stack trace on aborts and segfault. (Note: This doesn't always work.)
+#test:linux --config=segfault
+test:segfault --run_under="bash -c 'unset GREP_OPTIONS && if ! grep -q -o Microsoft /proc/version 2>/dev/null; then libs=\"$(command -v ldconfig >/dev/null && ldconfig -p | grep -F -o -e \"libSegFault.so\" | uniq | tr \"\\\\n\" :)\" && if [ -n \"${libs%:}\" ]; then export SEGFAULT_SIGNALS=\"abrt segv\" LD_PRELOAD=\"${libs}${LD_PRELOAD-}\"; fi; fi && \"$@\"' -"

.bazelversion

@@ -0,0 +1 @@
+3.3.0

.github/ISSUE_TEMPLATE/bug_report.md

@@ -2,7 +2,7 @@
 name: Bug report
 about: Report a bug on the latest version of Ray.
 title: ''
-labels: bug
+labels: bug, triage
 assignees: ''
 
 ---

.github/ISSUE_TEMPLATE/feature_request.md

@@ -2,7 +2,7 @@
 name: Feature request
 about: Suggest an idea for Ray, Tune, RLlib, etc.
 title: ''
-labels: enhancement
+labels: enhancement, triage
 assignees: ''
 
 ---

.github/ISSUE_TEMPLATE/question.md

@@ -1,6 +1,6 @@
 ---
 name: Question
-about: 'Ask a question about Ray usage. '
+about: 'Ask a question about Ray usage. For possible bugs, please use the "Bug Report" template instead.'
 title: ''
 labels: question
 assignees: ''

.github/workflows/main.yml

@@ -10,6 +10,12 @@ on:
       - master
       - releases/*
 
+env:
+  # Git GITHUB_... variables are useful for translating Travis environment variables
+  GITHUB_BASE_SHA: ${{ github.event.pull_request.base.sha }}
+  GITHUB_HEAD_SHA: ${{ github.event.pull_request.head.sha }}
+  GITHUB_PULL_REQUEST: ${{ github.event.number }}
+
 jobs:
   build:
     name: ${{ matrix.name }}
@@ -21,36 +27,82 @@ jobs:
         include:
           - name: ubuntu
             os: ubuntu-16.04
-          - name: windows
+            python-version: 3.6
+          - name: windows-msvc
             os: windows-2019
+            python-version: 3.8
+            # Can be 'msvc' or 'clang-cl'
+            config: msvc
           - name: macos
             os: macos-10.15
+            python-version: 3.6
     env:
-      PYTHON: 3.6
+      BAZEL_CONFIG: ${{ matrix.config }}
+      PYTHON: ${{ matrix.python-version }}
+      TRAVIS_COMMIT: ${{ github.sha }}
+      #TRAVIS_PULL_REQUEST is defined in the scripts to account for "false"
     steps:
     - name: Pre-checkout system configuration
       # We add -l to process .bashrc, but need -e -o pipefail for consistency with GitHub Actions's default behavior.
       shell: bash -e -o pipefail -l {0}
       run: |
         # Note: only configure settings here that are required _before_ the repository is cloned (such as Git settings).
-        if [ ! -f ~/.profile ] && [ ! -f ~/.bash_profile ]; then  # missing on some machines, but needed for ~/.bashrc
-          echo 'if [ -n "${BASH_VERSION}" ] && [ -f ~/.bashrc ]; then . ~/.bashrc; fi' >> ~/.profile
-        fi
+        # Different machines behave very differently with Bash initialization -- make them more uniform
+        rm -f -- ~/.bash_profile ~/.profile ~/.bashrc
+        printf '\n%s\n' 'if [ -n "${BASH_VERSION}" ] && [ -f ~/.bashrc ]; then . ~/.bashrc; fi' >> ~/.profile
         git config --global core.symlinks true && git config --global core.autocrlf false
         if command -v dpkg > /dev/null; then sudo dpkg-reconfigure debconf -f noninteractive -p high; fi
     - name: Checkout repository
-      uses: actions/checkout@v2
+      uses: actions/checkout@v1
+    - name: Configure AWS Credentials
+      continue-on-error: true
+      if: github.repository == 'ray-project/ray' && github.event_name != 'pull_request'
+      uses: aws-actions/configure-aws-credentials@v1
+      with:
+        aws-access-key-id: ${{ secrets.GHA_AWS_ACCESS_KEY_ID }}
+        aws-secret-access-key: ${{ secrets.GHA_AWS_SECRET_ACCESS_KEY }}
+        aws-region: us-west-2
+    - name: Prepare caching
+      id: info
+      shell: bash
+      run: |
+        case "${OSTYPE}" in
+          linux*) pip_cache=~/.cache/pip;;
+          darwin*) pip_cache=~/Library/Caches/pip;;
+          msys) pip_cache="${LOCALAPPDATA}\pip\Cache";;
+        esac
+        cat <<-EOF
+        ::set-output name=git_tree_hash::$(git cat-file -p HEAD | sed -n "s/^tree //p")
+        ::set-output name=pip_cache::${pip_cache}
+        EOF
+    - name: Cache (pip)
+      uses: actions/cache@v1.1.2
+      continue-on-error: true
+      if: steps.info.outputs.pip_cache
       with:
-        # we need full history to diff against the original for linting etc.
-        fetch-depth: 0
+        path: ${{ steps.info.outputs.pip_cache }}
+        key: |
+          pip-${{ runner.os }}-${{ steps.info.outputs.git_tree_hash }}
+        restore-keys: |
+          pip-${{ runner.os }}-
+          pip-
     - name: Run CI script
       shell: bash -e -o pipefail -l {0}
       env:
         BAZEL_CACHE_CREDENTIAL_B64: ${{ secrets.BAZEL_CACHE_CREDENTIAL_B64 }}
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        #LINUX_WHEELS: 1
+        #MAC_WHEELS: 1
+        RAY_DEFAULT_BUILD: 1
+        WINDOWS_WHEELS: 1
       run: |
+        python -u ci/remote-watch.py --skip_repo=ray-project/ray &
         . ./ci/travis/ci.sh init
         . ./ci/travis/ci.sh build
+        . ./ci/travis/ci.sh upload_wheels || true
+        . ./ci/travis/ci.sh test_python
+        . ./ci/travis/ci.sh test_core
+        . ./ci/travis/ci.sh test_wheels
     - name: Run Clang Include-What-You-Use
       continue-on-error: true
       if: runner.os == 'Linux'

.gitignore

@@ -168,12 +168,17 @@ venv
 # Vim
 .*.swp
 *.swp
+tags
+
+# Emacs
+.#*
 
 # tools
 tools/prometheus*
 
 # ray project files
 project-id
+.mypy_cache/
 
 # PyCharm
 .ijwb/