Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #990 #991

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fixes #990 #991

merged 1 commit into from
Nov 7, 2024

Conversation

avonville
Copy link
Contributor

Fixes minify still logging when debug is not checked.

Testing

  1. Flush cache
  2. Go to the site and monitor wp-content/cache/log/000000/minify.log
  3. The log file should not have any new entries.

@avonville avonville requested a review from cssjoe November 7, 2024 17:09
@avonville avonville self-assigned this Nov 7, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 0.89%. Comparing base (a9d7c0b) to head (7a8dc50).

Files with missing lines Patch % Lines
Minify_MinifiedFileRequestHandler.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             master    #991      +/-   ##
===========================================
- Coverage      0.89%   0.89%   -0.01%     
- Complexity    19697   19698       +1     
===========================================
  Files           679     679              
  Lines         99411   99413       +2     
===========================================
  Hits            893     893              
- Misses        98518   98520       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cssjoe cssjoe added this to the 2.8.0 milestone Nov 7, 2024
@cssjoe cssjoe merged commit 01a91cf into master Nov 7, 2024
2 checks passed
@cssjoe cssjoe deleted the issue-990 branch November 7, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants