Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings not saved in the Cloudflare extension #981

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Settings not saved in the Cloudflare extension #981

merged 4 commits into from
Oct 29, 2024

Conversation

avonville
Copy link
Contributor

Fixes #943

@avonville avonville requested a review from cssjoe October 29, 2024 18:28
@cssjoe cssjoe changed the title Issue 943 Settings not saved in the Cloudflare extension Oct 29, 2024
@cssjoe cssjoe added this to the 2.8.0 milestone Oct 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 0.90%. Comparing base (1d71136) to head (8617ff4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
Extension_CloudFlare_GeneralPage_View.php 0.00% 26 Missing ⚠️
Extension_CloudFlare_Page_View.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             master    #981   +/-   ##
========================================
  Coverage      0.90%   0.90%           
  Complexity    19602   19602           
========================================
  Files           677     677           
  Lines         98764   98736   -28     
========================================
  Hits            893     893           
+ Misses        97871   97843   -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cssjoe cssjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The link to General Settings needs to be updated -- see comment.
  • Not required, but you may want to add an "Advanced Settings" tab on the General Settings Cloudflare section to go to the extension settings page.

Extension_CloudFlare_Page_View.php Outdated Show resolved Hide resolved
@avonville avonville requested a review from cssjoe October 29, 2024 20:00
@cssjoe cssjoe merged commit cbfc528 into master Oct 29, 2024
2 checks passed
@cssjoe cssjoe deleted the issue-943 branch October 29, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings not saved in the Cloudflare extension
3 participants