WP cron option to purge caches on schedule #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ell as on the general settings page for all caches.
…not scheduling consistently or when settings were modified.
…nto cron-flush
…onfig" and caused the Always Cached to malfunction.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #971 +/- ##
===========================================
- Coverage 0.90% 0.89% -0.01%
- Complexity 19609 19697 +88
===========================================
Files 679 679
Lines 98868 99358 +490
===========================================
Hits 893 893
- Misses 97975 98465 +490 ☔ View full report in Codecov by Sentry. |
…ts. Re-enabled the fix_on_event for all caches.
cssjoe
requested changes
Oct 29, 2024
…nto cron-flush
…chedule timestamp calculations.
cssjoe
requested changes
Nov 4, 2024
There was a problem hiding this comment.
Users don't have an option to choose a timezone different from the WP site timezone, so there is no "timezone" in user meta. You can just set the variable to wp_timezone(). If it's only used once in a method, then use wp_timezone() there.
When I enable the feature and choose a time in the past, I don't see the WP Cron event scheduled if I choose anything other than "weekly".
cssjoe
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds a new option on the General settings page and on the advanced setting pages for Page, DB, Minify, and Object caches. This new option is it's own meta box containing an enable checkbox and a time and interval selector to define when the WP cron event should be run and on what interval. These cron events simply call a flush on the relevant cache