Skip to content

sui_v1.33.0_1725500826_ci

sui_v1.33.0_1725500826_ci: test(graphql): Remove explicit cleanup_resources (#19201)
@amnn amnn tagged this 05 Sep 00:04 
## Description
These were originally added to try and deal with a deadlock issue, which
was due to an issue with `inotify` on macOS, fixed by #19195.

These calls are safe to remove (also note that if the test failed, they
would never be hit, because the assert would cause a panic before they
ran).

## Test plan

Rebase on top of #19195, run the following on macOS:

```
sui$ cargo nextest run       \
  -j 1 -p sui-graphql-rpc    \
  --test e2e_tests           \
  --features pg_integration
```

This used to intermittently hang, but now succeeds.

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:
Assets 2
Loading