Code cleanup, fixes and deprecation of .NET 6 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the `-installDotNetAdmin` command line case and the `InstallDotNet` method from the application. Deleted the `DotNetInstallerWindow` and its associated logic. Updated the project version to `0.9.012` and the target framework to `net8.0-windows10.0.22000.0`. Updated the `LibreHardwareMonitorLib` package reference to `0.9.4-pre335`. Removed the `OpenNETInstaller` button and its event handler from the main window.
Completely removed the WPF application structure, including: - App.xaml and App.xaml.cs files - MainWindow.xaml and MainWindow.xaml.cs files - Various service and module implementations - WPF-specific settings and dependencies in MagicChatboxV2.csproj Removed the LoadingWindow feature, including: - LoadingWindow.xaml and LoadingWindow.xaml.cs files - LoadingWindowViewModel.cs file Updated vrcosc-magicchatbox.sln to remove MagicChatboxV2 project and its build configurations.
- Changed `MiddleCharacter` in `DataController.cs` from "✦" to "✴". - Updated `LibreHardwareMonitorLib` in `MagicChatbox.csproj` from `0.9.4-pre335` to `0.9.4-pre338`.
Updated `CurrentDomain_FirstChanceException` in `App.xaml.cs` to ignore exceptions with the message "The process cannot access the file". This prevents logging of these specific exceptions. Incremented version number in `MagicChatbox.csproj` from `0.9.012` to `0.9.013`.
The version number of the project has been updated from 0.9.013 to 0.9.015.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Classification
Code cleanup and deprecation of .NET installer functionality.
PR Summary
Removed .NET installer functionality and related UI components, updated project configurations.
LoadingWindow.xaml,LoadingWindow.xaml.cs, andLoadingWindowViewModel.cs.vrcosc-magicchatbox.slnto removeMagicChatboxV2project.App.xaml.csto remove .NET installer case and handle specific exceptions.MagicChatbox.csprojto new version and target framework.DotNetInstallerWindow.xamland its implementation inDotNetInstallerWindow.xaml.cs.