Enable all Python warnings in the test suite #638
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables all warnings in the test suite when run in tox.
With this change, additional
ResourceWarning
warnings display. For example:Through trial and error I was able to isolate these four open files to the following test (other tests in that file only trigger warnings about three or fewer unclosed files):
I've not yet identified how these files are getting opened, but with the changes in this PR, it'll be obvious when this issue is resolved.