Add support for Apple file list types for validation #68
Conversation
|
@kehoecj Tried to check plist files and did a basic validation similar to other ones for JSON etc. Let me know if this is fine. |
kehoecj
added
OSS Community Contribution
|
@sandyydk Please resolve merge conflicts from two PR's that have been merged |
|
Will do. I will update the PR. Thanks
…On Tue, 17 Oct, 2023, 9:38 pm Clayton Kehoe, ***@***.***> wrote:
@sandyydk <https://github.com/sandyydk> Please resolve merge conflicts
from two PR's that have been merged
—
Reply to this email directly, view it on GitHub
<#68 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIORR3XGREFBLMVRD5CIY3X72URHAVCNFSM6AAAAAA6AMEIQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRWG4ZTEMBUGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Sure. Will update the PR for the same. I was thinking if we should go with
sub directories within validators to include these test files? If not will
go with constant itself.
…On Wed, 18 Oct, 2023, 8:26 pm Clayton Kehoe, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On pkg/validator/valid.plist
<#68 (comment)>
:
I would prefer to keep test files out of the pkg directory. Would rather
just use a few variables in the tests themselves than have a test file in
the pkg dir.
—
Reply to this email directly, view it on GitHub
<#68 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIORR65JVU23N54LL4A3GTX77U23AVCNFSM6AAAAAA6AMEIQCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOBVGMZDCNBVGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Would prefer constants for now |
| import ( | ||
| "bytes" | ||
|
|
||
| "howett.net/plist" |
There was a problem hiding this comment.
https://pkg.go.dev/howett.net/plist#section-readme states four different plist formats are supported (Apple XML, Apple Binary, OpenStep and GNUStep). Looks like this only tests the XML variant. Are there plans to add support and tests for the other three?
There was a problem hiding this comment.
Added a task to #60 to specify that only Apple XML is supported. I'll take a look into the other plist types and see how widely used they are and if they are worth supporting.
* Add support for Apple file list types for validation * Fix merge conflicts * Move large strings from test cases to an embedded file * Move large text in test case to a variable
* Add support for Apple file list types for validation * Fix merge conflicts * Move large strings from test cases to an embedded file * Move large text in test case to a variable
Changes in this PR
Closes #66