fix(cli): stop after global help#552
Open
floze-the-genius wants to merge 1 commit into
Open
Conversation
kehoecj
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flag.ErrHelpcfv --helpReproduction
While testing the v3 release candidate for #551, running
cfv --helpprinted usage and then continued into the defaultcheckcommand. In a directory containing invalid configuration files, help therefore emitted validation results and exited with status 1.After this change,
cfv --helpprints usage, performs no validation, and exits 0.Validation
go vet ./...test -z "$(gofmt -s -l -e .)"golangci-lint run ./...(0 issues)go generate ./pkg/filetype/...go build -o /dev/null cmd/cfv/cfv.gogo test -cover -coverprofile coverage.out ./...go tool cover -func coverage.out | grep total(91.0%)