Fix/546 xml optional dtd validation#548
Open
addielaruee wants to merge 2 commits into
Open
Conversation
helium v0.5.0+ requires a DOCTYPE to be present whenever ValidateDTD(true) is set, so well-formed XML without a DTD now fails to parse. Pre-scan the input for <!DOCTYPE and only enable DTD validation when one exists, restoring the tool's intended behavior: - well-formed XML, no DTD -> syntax-only pass - XML with a DTD -> validated against it Also fixes the dtd_and_xsd.xml test fixture: it combines a DTD with xsi:noNamespaceSchemaLocation but never declared those attributes via ATTLIST, which v0.5.1's stricter conformance now correctly rejects as undeclared attributes. Closes Boeing#546
kehoecj
added
OSS Community Contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #546.