feat(validation): Add support for properties files #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…array of properties Signed-off-by: gokulav137 <gokulav999@gmail.com>
Signed-off-by: gokulav137 <gokulav999@gmail.com>
…lidator Signed-off-by: gokulav137 <gokulav999@gmail.com>
Signed-off-by: gokulav137 <gokulav999@gmail.com>
Signed-off-by: gokulav137 <gokulav999@gmail.com>
|
Thanks for the PR and contribution! We'll take a look as soon as we can |
kehoecj
added
OSS Community Contribution
|
Need to update this section of the README to include properties files |
kehoecj
requested changes
Oct 5, 2023
jackswiney
approved these changes
Oct 5, 2023
Signed-off-by: gokulav137 <gokulav999@gmail.com>
Signed-off-by: gokulav137 <gokulav999@gmail.com>
Signed-off-by: gokulav137 <gokulav999@gmail.com>
Signed-off-by: gokulav137 <gokulav999@gmail.com>
kehoecj
approved these changes
Oct 5, 2023
Signed-off-by: gokulav137 <gokulav999@gmail.com>
|
Merged! Thank you for your contribution @gokulav137 💯 |
|
Thanks for all the support @kehoecj |
shiina4119
pushed a commit
to shiina4119/config-file-validator
that referenced
this pull request
Aug 23, 2024
* Add PropValidator which impliments Validator interface to prase byte array of properties Signed-off-by: gokulav137 <gokulav999@gmail.com> * Add valid and invalid scenarios for testing PropValidator Signed-off-by: gokulav137 <gokulav999@gmail.com> * Add PropFiletype to represent properties file and mapped it to PropValidator Signed-off-by: gokulav137 <gokulav999@gmail.com> * Add good and bad .properties files to test/fixtures Signed-off-by: gokulav137 <gokulav999@gmail.com> * Fix typo in test name: Properites -> Properties Signed-off-by: gokulav137 <gokulav999@gmail.com> * Add magiconair/properties to go.mod Signed-off-by: gokulav137 <gokulav999@gmail.com> * Add Properties to supported types in README Signed-off-by: gokulav137 <gokulav999@gmail.com> * Fix padding issue for multiline validation errors Signed-off-by: gokulav137 <gokulav999@gmail.com> * Add test case to cover multiline error padding case Signed-off-by: gokulav137 <gokulav999@gmail.com> * Add doc comment for padErrorString method Signed-off-by: gokulav137 <gokulav999@gmail.com> --------- Signed-off-by: gokulav137 <gokulav999@gmail.com>
shiina4119
pushed a commit
to shiina4119/config-file-validator
that referenced
this pull request
Oct 4, 2024
* Add PropValidator which impliments Validator interface to prase byte array of properties Signed-off-by: gokulav137 <gokulav999@gmail.com> * Add valid and invalid scenarios for testing PropValidator Signed-off-by: gokulav137 <gokulav999@gmail.com> * Add PropFiletype to represent properties file and mapped it to PropValidator Signed-off-by: gokulav137 <gokulav999@gmail.com> * Add good and bad .properties files to test/fixtures Signed-off-by: gokulav137 <gokulav999@gmail.com> * Fix typo in test name: Properites -> Properties Signed-off-by: gokulav137 <gokulav999@gmail.com> * Add magiconair/properties to go.mod Signed-off-by: gokulav137 <gokulav999@gmail.com> * Add Properties to supported types in README Signed-off-by: gokulav137 <gokulav999@gmail.com> * Fix padding issue for multiline validation errors Signed-off-by: gokulav137 <gokulav999@gmail.com> * Add test case to cover multiline error padding case Signed-off-by: gokulav137 <gokulav999@gmail.com> * Add doc comment for padErrorString method Signed-off-by: gokulav137 <gokulav999@gmail.com> --------- Signed-off-by: gokulav137 <gokulav999@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to validate properties files with .properties extension
uses: https://pkg.go.dev/github.com/magiconair/properties
resolves: #51