Skip to content

Sprite pushImage support for 8-bit sprites and transparency from PROGMEM#3794

Open
elatorre20 wants to merge 1 commit intoBodmer:masterfrom
elatorre20:progmem_drawing
Open

Sprite pushImage support for 8-bit sprites and transparency from PROGMEM#3794
elatorre20 wants to merge 1 commit intoBodmer:masterfrom
elatorre20:progmem_drawing

Conversation

@elatorre20
Copy link

Adds a definition of the pushImage function for sprites to push an 8-bit bitmap from PROGMEM to a sprite, with optional transparency. This is analogous to the existing pushImage functionality, but with support for 8 bits per pixel images rather than 16 bits.

Adds a definition of the pushImage function for sprites to push an 8-bit bitmap from PROGMEM to a sprite, with optional transparency. This is analogous to the existing pushImage functionality, but with support for 8 bits per pixel images rather than 16 bits.
Copy link
Owner

@Bodmer Bodmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a new function a new sprite example is needed to demonstrate usage, otherwise the function will be missed.

The example will also allow me to test the change.

Make sure the example tests 8 >16 bit sprite and 8 > 8 bit sprite. State in the example that 8 > 4bpp and 8 > 1bpp is not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants