kernel::linux: restore behaviour of LINUX_CONFIG #134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the refactoring the Linux kernel recipe into a reusable class, the LINUX_CONFIG variable was automatically suffixed with "_defconfig" to find the defconfig in the Linux source tree. Restore the old behaviour. Fixes: 5941b74 ("kernel::linux: use the new linux classes")
Contributor
|
No real opinion. I think the user can specify the _defconfig extension. Than it is also obvious for the caller that this is a defconfig. But if it breaks existing stuff, than, sure, restore the old behavior. |
Contributor
|
We have a completely different linux recipe anyway... |
Member
Author
|
I'll drop this. It makes sense that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the refactoring the Linux kernel recipe into a reusable class, the LINUX_CONFIG variable was automatically suffixed with "_defconfig" to find the defconfig in the Linux source tree. Restore the old behaviour.
Fixes: 5941b74 ("kernel::linux: use the new linux classes")
@sixtyfourktec @rhubert Any opinion? We could as well adapt the old recipes (bob-example-embedded in particular)...