Skip to content

Fix NotionClientException when coroutine is cancelled #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2021
Merged

Fix NotionClientException when coroutine is cancelled #22

merged 1 commit into from
Dec 6, 2021

Conversation

yujinyan
Copy link
Contributor

@yujinyan yujinyan commented Dec 6, 2021

Issue:

When the coroutine is cancelled, the client now throws NotionClientException.

Expected behaviour:

It should just cancel quietly.

BoD
BoD approved these changes Dec 6, 2021
View reviewed changes
Copy link
Owner

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks a lot 👍

@BoD BoD merged commit ef5739e into BoD:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yujinyan @BoD