-
Notifications
You must be signed in to change notification settings - Fork 5
oxc migration - migrate from eslint to oxlint, remove node 18 explicit support #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0f19f08:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'benchmarkjs, node 22'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: 0f19f08 | Previous: a476634 | Ratio |
|---|---|---|---|
create empty, size: 2e6 |
7908 ops/sec (±1.09%) |
10544 ops/sec (±0.66%) |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @Bnaya
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
benchmarkjs, node 20
Details
| Benchmark suite | Current: 0f19f08 | Previous: a476634 | Ratio |
|---|---|---|---|
create empty, size: 2e6 |
6027 ops/sec (±3.13%) |
11368 ops/sec (±1.62%) |
1.89 |
create with 2500 comments. size: 2e6 |
156 ops/sec (±0.63%) |
165 ops/sec (±0.24%) |
1.06 |
save 2500 comments into pre-created OB, size: 2e6 |
150 ops/sec (±1.35%) |
156 ops/sec (±1.15%) |
1.04 |
create with all mock data rows. size: 2e6 |
166 ops/sec (±1.01%) |
175 ops/sec (±0.82%) |
1.05 |
A-Z object keys |
40971 ops/sec (±0.20%) |
41894 ops/sec (±0.38%) |
1.02 |
A-Z object prop Lookup in operator - non-existing |
13754402 ops/sec (±0.55%) |
13609010 ops/sec (±0.24%) |
0.99 |
A-Z object prop Lookup in operator - existing |
2880545 ops/sec (±0.26%) |
2810921 ops/sec (±0.20%) |
0.98 |
A-Z object prop access T |
2655480 ops/sec (±0.21%) |
2800096 ops/sec (±0.20%) |
1.05 |
A-Z object prop access Z |
2656149 ops/sec (±0.21%) |
2806156 ops/sec (±0.18%) |
1.06 |
OB_WITH_NA2Z_KEYS object keys |
25472 ops/sec (±0.21%) |
26626 ops/sec (±0.25%) |
1.05 |
OB_WITH_NA2Z_KEYS object prop Lookup in operator - non-existing |
1661592 ops/sec (±0.30%) |
1624045 ops/sec (±1.04%) |
0.98 |
OB_WITH_NA2Z_KEYS object prop Lookup in operator - existing |
1636384 ops/sec (±0.20%) |
1648423 ops/sec (±0.13%) |
1.01 |
OB_WITH_NA2Z_KEYS object prop access 14ABCDEFGHIJKLMNOPQRSTUVWXYZ |
1598800 ops/sec (±0.26%) |
1655082 ops/sec (±0.19%) |
1.04 |
OB_WITH_NA2Z_KEYS object prop access 3ABCDEFGHIJKLMNOPQRSTUVWXYZ |
1622646 ops/sec (±0.22%) |
1673817 ops/sec (±0.14%) |
1.03 |
Array access. length: 1000 |
3890671 ops/sec (±0.32%) |
3799051 ops/sec (±0.33%) |
0.98 |
object memory free. K1000RowsMockData, pre-created OB, size: 2e6 |
17.22 ops/sec (±0.71%) |
17.61 ops/sec (±0.61%) |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'benchmarkjs, node 20'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: 0f19f08 | Previous: a476634 | Ratio |
|---|---|---|---|
create empty, size: 2e6 |
6027 ops/sec (±3.13%) |
11368 ops/sec (±1.62%) |
1.89 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @Bnaya
No description provided.