ENH/API: Multi-Dimensional Tuple Support For StringArray and NeighborList #1439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imikejackson
added a commit
to BlueQuartzSoftware/SimplnxReview
that referenced
this pull request
Sep 23, 2025
Depends on SIMPLNX PR BlueQuartzSoftware/simplnx#1439
nyoungbq
force-pushed
the
enh/issue_1359
branch
from
e5af132 to
fd99910
Compare
mmarineBlueQuartz
approved these changes
Sep 26, 2025
nyoungbq
force-pushed
the
enh/issue_1359
branch
2 times, most recently
from
5b630f5 to
3a46e03
Compare
imikejackson
added a commit
to BlueQuartzSoftware/SimplnxReview
that referenced
this pull request
Sep 30, 2025
Depends on SIMPLNX PR BlueQuartzSoftware/simplnx#1439
- Reworked Store-NeighborList interaction to mirror Store-DataArray paradigms - NeighborList and INeighborList API cleanup
imikejackson
force-pushed
the
enh/issue_1359
branch
from
3a46e03 to
95004c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1359
Fixes: #1260
Has a NX counterpart.
This PR makes several changes to the backend in one fell swoop, including:
NeighborListandStringArrayNeighborListandStringArraymodernization (information about underlying data is now held in Stores)ShapeTypealias has been centralized and usages have been updatedNeighborListandStringArrayand all relevant abstract interfaces and storesUnitTest::CheckArraysInheritTupleDimsnow validates all objects in anAttributeMatrix