Make render interval slightly more configurable#698
Make render interval slightly more configurable#698iczero wants to merge 1 commit intoBlueMap-Minecraft:masterfrom
Conversation
|
I strongly believe, that there is a misunderstanding with what the C2ME config comment means and what this actually means for bluemaps update file-watchers. Having an actual region-file-change every tick, meaning:
would be a ton of absolutely wasted performance on minecrafts side, i somehow doubt they actually do that :D I would love to see some testing on this, e.g. a log that logs every time bluemap detected a file-change. If that really shows multiple file-changes on a single region-file within a minute, then we can talk about adding these config-options :) Also keep in mind that bluemap does more checks before actually rendering anything. A chunk is only updated if its internal timestamp changed -> bluemap won't re-render an entire region-file just because a single chunk changed in it :) |
|
I've run Also I can confirm that this patch dropped server CPU usage while any players were active significantly. Running Edit: Issue was not reproduced by the community. Please comment if you also have this problem. |
|
We talked about this on discord, but just to have this documented in the right place :) ... Keep the 5 second delay from file-change normally, but add a (configurable) minimum time between re-renders of the same region which defaults to 1 minute. A |
|
Implemented with cde3ba0. |
It seems that at some point, autosave was changed to be a lot more frequent. According to C2ME:
As a result, by default, it seems that BlueMap will rerender chunks every 5 to 10 seconds. This is currently not configurable. This is useful when the user wants changes to be reflected almost immediately; otherwise, the server effectively wastes cycles rendering chunks that nobody will see, only to render them again 10 seconds later.
This PR adds two configuration options:
update-region-after-inactivity: Wait for approximately this many seconds of inactivity on the region file before rerendering it.update-region-max-inactivity-wait: Approximate max amount of time to wait before rerendering the region anyways.Setting these to higher values will slow down rendering. This should help on both Vanilla and C2ME servers.