This repository was archived by the owner on Feb 26, 2025. It is now read-only.
remove pdf documentation#412
Merged
AurelienJaquier merged 17 commits intoBlueBrain:masterfrom Nov 6, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #412 +/- ##
==========================================
- Coverage 91.73% 91.51% -0.22%
==========================================
Files 36 39 +3
Lines 6278 7744 +1466
Branches 2033 2366 +333
==========================================
+ Hits 5759 7087 +1328
- Misses 266 316 +50
- Partials 253 341 +88 ☔ View full report in Codecov by Sentry. |
added 10 commits
October 30, 2024 10:55
Contributor
darshanmandge
left a comment
There was a problem hiding this comment.
Thanks @AurelienJaquier ! Could you also update the PR description and Changelog to mention all the indices features added?:
added to features docs: check_ais_initiation, bpap_attenuation, all indices features
Users might misunderstand that the "all indices features" is one efel feature :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was no substantial information in the pdf that were not already present in the official doc. The official doc was based on the pdf I believe, so many things were similar. But since the doc has been kept up to date, it is actually more detailed than the pdf, exception to the algorithm descriptions.
Also did:
Checklist: