Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

perf: reduce cppcore initialisation#410

Merged
ilkilic merged 4 commits intomasterfrom
optimise-cppcore-init
Sep 3, 2024
Merged

perf: reduce cppcore initialisation#410
ilkilic merged 4 commits intomasterfrom
optimise-cppcore-init

Conversation

@ilkilic
Copy link
Collaborator

@ilkilic ilkilic commented Sep 3, 2024

Description

Reduces redundant dependency tree initialisations in cppcore, improving feature extraction performance by up to 2.5x. The change ensures getFeatureValues avoids unnecessary resets, with efel.reset available for reloading dependencies when needed.

Checklist:

  • Unit tests are added to cover the changes (skip if not applicable).
  • The changes are mentioned in the documentation (skip if not applicable).
  • CHANGELOG file is updated (skip if not applicable).

@ilkilic ilkilic self-assigned this Sep 3, 2024
Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@ilkilic ilkilic merged commit 6f15c98 into master Sep 3, 2024
@ilkilic ilkilic deleted the optimise-cppcore-init branch September 3, 2024 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants