This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Fix vector constructor ambiguity in H5DataType.hpp #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the code in H5DataType.hpp to fix the compilation error caused by a vector constructor ambiguity when _GLIBCXX_DEBUG is defined. Replaced std::vector<member_def>({t_members}) with std::vector<member_def>(t_members) to eliminate unnecessary copy constructor calls.
alkino
approved these changes
Jun 19, 2023
Codecov Report
@@ Coverage Diff @@
## master #775 +/- ##
=======================================
Coverage 83.94% 83.94%
=======================================
Files 67 67
Lines 4602 4602
=======================================
Hits 3863 3863
Misses 739 739
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #774