BRAYNS-316 Remove assimp #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NadirRoGue
reviewed
Jan 24, 2022
.gitlab-ci.viz.yml
Outdated
| @@ -1,16 +1,13 @@ | |||
| stages: | |||
| - test | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Why the removal of the blank lines? I added them for split clarity between jobs and env config.
There was a problem hiding this comment.
Oh sorry it seems it is the auto formatter, I will remove it.
NadirRoGue
reviewed
Jan 24, 2022
brayns/io/loaders/MeshLoader.cpp
Outdated
| constexpr float TOTAL_PROGRESS = 100.f; | ||
| constexpr float LOADING_FRACTION = 50.f; | ||
| constexpr float POST_LOADING_FRACTION = 50.f; | ||
| using namespace brayns; |
There was a problem hiding this comment.
using namespace can lead to issues later, it is better to avoid them.
NadirRoGue
reviewed
Jan 24, 2022
brayns/io/loaders/MeshLoader.h
Outdated
| * Materials are not extracted. | ||
| * | ||
| * A default white material is used for the mesh model. | ||
| * | ||
| */ | ||
| class MeshLoader : public Loader<MeshLoaderParameters> |
There was a problem hiding this comment.
Since the load configuration parameters are not used anymore, MeshLoader can extend NoInputLoader and avoid the (void)parameters on the source file?
There was a problem hiding this comment.
Also we can get rid of the MeshLoaderParameters.h file
NadirRoGue
previously approved these changes
Jan 24, 2022
NadirRoGue
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assimp replaced by custom mesh parsers (no libraries).
Supports files OBJ, PLY, STL and OFF.
No materials extracted, just a default white one for the whole mesh.
No triangulation (only supports triangular faces).
Vertex duplication for all formats (vertex count = index count).
An OBJ file can contain multiple objects.
A PLY file can have position, normal, color and texture coordinates (vertex + face) in vertices.
STL complete support.
Only positions supported in OFF files.