Replace FFmpeg system call by dev libraries #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MovieMaker class. - FFmpeg libraries abstraction layer. - Error handling. - Disable movie generation in CMake if FFmpeg libraries not found.
|
Could you retest this please. |
NadirRoGue
reviewed
May 19, 2021
There was a problem hiding this comment.
In my opinion, I wouldn't implement this feature with a complex architecture. As we are trying to simplify Brayns code base, and the features of the movie making are focused only for one entry point, I would use a single class which implements the whole process.
Adrien4193
changed the title
Replaced CMake source file selection by macro. Added STATUS to CMake messages.
NadirRoGue
approved these changes
May 20, 2021
plugins/CircuitExplorer/plugin/movie/ffmpeg/conversion/ConversionContext.h
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Movie generation implemented and tested on WebBrayns.